From: Paul Parsons <lost.distance@yahoo.com>
To: Philipp Zabel <philipp.zabel@gmail.com>
Cc: linux-kernel@vger.kernel.org, mad_soft@inbox.ru,
koen@dominion.thruhere.net, cbouatmailru@gmail.com
Subject: Re: [PATCH] power/ds2760_battery: Add rated capacity of the hx4700 3600mAh battery
Date: Thu, 24 Nov 2011 23:52:56 +0000 (GMT) [thread overview]
Message-ID: <1322178776.45812.YahooMailClassic@web29011.mail.ird.yahoo.com> (raw)
In-Reply-To: <CA+gwMcf9xvcFNJoxmDO0z-FMhKrd=9eptSDrpsBB3a20pzMfKw@mail.gmail.com>
--- On Thu, 24/11/11, Philipp Zabel <philipp.zabel@gmail.com> wrote:
> > +#ifdef CONFIG_MACH_H4700
> > + 0,
> > + 3600, /* HP iPAQ hx4700 3.7V 3600mAh
> (359114-001) */
> > +#endif
>
> Is that #ifdef needed? I know there's another one a few
> lines up, but
> I think that one is already unfortunate and there is no
> conflict here.
Yes it is needed, because the rated_capacities[] table must contain different values for different platforms. The #ifdefs preserve the original table for other platforms.
Agreed it's untidy. Ideally the table would be replaced by platform specific data. However it's not obvious which other platforms use the table, nor whether the original table is correct for those other platforms. I presume that the table was originally believed to be common for all ds2760 based platforms, but the hx4700 demonstrates this is not the case.
next prev parent reply other threads:[~2011-11-24 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 22:37 Paul Parsons
2011-11-24 18:16 ` Philipp Zabel
2011-11-24 23:52 ` Paul Parsons [this message]
2011-11-25 23:56 ` Anton Vorontsov
2011-11-26 0:43 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322178776.45812.YahooMailClassic@web29011.mail.ird.yahoo.com \
--to=lost.distance@yahoo.com \
--cc=cbouatmailru@gmail.com \
--cc=koen@dominion.thruhere.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®