mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Cong Wang <amwang@redhat.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Robert Jennings <rcj@linux.vnet.ibm.com>,
	Pekka Enberg <penberg@kernel.org>,
	Nitin Gupta <ngupta@vflare.org>, Peter Huewe <peterhuewe@gmx.de>,
	Jerome Marchand <jmarchan@redhat.com>,
	Jeff Moyer <jmoyer@redhat.com>,
	devel@driverdev.osuosl.org
Subject: [PATCH 26/62] zram: remove the second argument of k[un]map_atomic()
Date: Sun, 27 Nov 2011 13:27:06 +0800	[thread overview]
Message-ID: <1322371662-26166-27-git-send-email-amwang@redhat.com> (raw)
In-Reply-To: <1322371662-26166-1-git-send-email-amwang@redhat.com>


Signed-off-by: Cong Wang <amwang@redhat.com>
---
 drivers/staging/zram/xvmalloc.c |   39 ++++++++++++++++-----------------
 drivers/staging/zram/zram_drv.c |   44 +++++++++++++++++++-------------------
 2 files changed, 41 insertions(+), 42 deletions(-)

diff --git a/drivers/staging/zram/xvmalloc.c b/drivers/staging/zram/xvmalloc.c
index 1f9c508..93ba8e9 100644
--- a/drivers/staging/zram/xvmalloc.c
+++ b/drivers/staging/zram/xvmalloc.c
@@ -56,17 +56,17 @@ static void clear_flag(struct block_header *block, enum blockflags flag)
  * This is called from xv_malloc/xv_free path, so it
  * needs to be fast.
  */
-static void *get_ptr_atomic(struct page *page, u16 offset, enum km_type type)
+static void *get_ptr_atomic(struct page *page, u16 offset)
 {
 	unsigned char *base;
 
-	base = kmap_atomic(page, type);
+	base = kmap_atomic(page);
 	return base + offset;
 }
 
-static void put_ptr_atomic(void *ptr, enum km_type type)
+static void put_ptr_atomic(void *ptr)
 {
-	kunmap_atomic(ptr, type);
+	kunmap_atomic(ptr);
 }
 
 static u32 get_blockprev(struct block_header *block)
@@ -202,10 +202,10 @@ static void insert_block(struct xv_pool *pool, struct page *page, u32 offset,
 
 	if (block->link.next_page) {
 		nextblock = get_ptr_atomic(block->link.next_page,
-					block->link.next_offset, KM_USER1);
+					block->link.next_offset);
 		nextblock->link.prev_page = page;
 		nextblock->link.prev_offset = offset;
-		put_ptr_atomic(nextblock, KM_USER1);
+		put_ptr_atomic(nextblock);
 		/* If there was a next page then the free bits are set. */
 		return;
 	}
@@ -225,18 +225,18 @@ static void remove_block(struct xv_pool *pool, struct page *page, u32 offset,
 
 	if (block->link.prev_page) {
 		tmpblock = get_ptr_atomic(block->link.prev_page,
-				block->link.prev_offset, KM_USER1);
+				block->link.prev_offset);
 		tmpblock->link.next_page = block->link.next_page;
 		tmpblock->link.next_offset = block->link.next_offset;
-		put_ptr_atomic(tmpblock, KM_USER1);
+		put_ptr_atomic(tmpblock);
 	}
 
 	if (block->link.next_page) {
 		tmpblock = get_ptr_atomic(block->link.next_page,
-				block->link.next_offset, KM_USER1);
+				block->link.next_offset);
 		tmpblock->link.prev_page = block->link.prev_page;
 		tmpblock->link.prev_offset = block->link.prev_offset;
-		put_ptr_atomic(tmpblock, KM_USER1);
+		put_ptr_atomic(tmpblock);
 	}
 
 	/* Is this block is at the head of the freelist? */
@@ -249,11 +249,10 @@ static void remove_block(struct xv_pool *pool, struct page *page, u32 offset,
 		if (pool->freelist[slindex].page) {
 			struct block_header *tmpblock;
 			tmpblock = get_ptr_atomic(pool->freelist[slindex].page,
-					pool->freelist[slindex].offset,
-					KM_USER1);
+					pool->freelist[slindex].offset);
 			tmpblock->link.prev_page = NULL;
 			tmpblock->link.prev_offset = 0;
-			put_ptr_atomic(tmpblock, KM_USER1);
+			put_ptr_atomic(tmpblock);
 		} else {
 			/* This freelist bucket is empty */
 			__clear_bit(slindex % BITS_PER_LONG,
@@ -284,7 +283,7 @@ static int grow_pool(struct xv_pool *pool, gfp_t flags)
 	stat_inc(&pool->total_pages);
 
 	spin_lock(&pool->lock);
-	block = get_ptr_atomic(page, 0, KM_USER0);
+	block = get_ptr_atomic(page, 0);
 
 	block->size = PAGE_SIZE - XV_ALIGN;
 	set_flag(block, BLOCK_FREE);
@@ -293,7 +292,7 @@ static int grow_pool(struct xv_pool *pool, gfp_t flags)
 
 	insert_block(pool, page, 0, block);
 
-	put_ptr_atomic(block, KM_USER0);
+	put_ptr_atomic(block);
 	spin_unlock(&pool->lock);
 
 	return 0;
@@ -375,7 +374,7 @@ int xv_malloc(struct xv_pool *pool, u32 size, struct page **page,
 		return -ENOMEM;
 	}
 
-	block = get_ptr_atomic(*page, *offset, KM_USER0);
+	block = get_ptr_atomic(*page, *offset);
 
 	remove_block(pool, *page, *offset, block, index);
 
@@ -405,7 +404,7 @@ int xv_malloc(struct xv_pool *pool, u32 size, struct page **page,
 	block->size = origsize;
 	clear_flag(block, BLOCK_FREE);
 
-	put_ptr_atomic(block, KM_USER0);
+	put_ptr_atomic(block);
 	spin_unlock(&pool->lock);
 
 	*offset += XV_ALIGN;
@@ -426,7 +425,7 @@ void xv_free(struct xv_pool *pool, struct page *page, u32 offset)
 
 	spin_lock(&pool->lock);
 
-	page_start = get_ptr_atomic(page, 0, KM_USER0);
+	page_start = get_ptr_atomic(page, 0);
 	block = (struct block_header *)((char *)page_start + offset);
 
 	/* Catch double free bugs */
@@ -468,7 +467,7 @@ void xv_free(struct xv_pool *pool, struct page *page, u32 offset)
 
 	/* No used objects in this page. Free it. */
 	if (block->size == PAGE_SIZE - XV_ALIGN) {
-		put_ptr_atomic(page_start, KM_USER0);
+		put_ptr_atomic(page_start);
 		spin_unlock(&pool->lock);
 
 		__free_page(page);
@@ -486,7 +485,7 @@ void xv_free(struct xv_pool *pool, struct page *page, u32 offset)
 		set_blockprev(tmpblock, offset);
 	}
 
-	put_ptr_atomic(page_start, KM_USER0);
+	put_ptr_atomic(page_start);
 	spin_unlock(&pool->lock);
 }
 EXPORT_SYMBOL_GPL(xv_free);
diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index 09de99f..fa276c0 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -161,9 +161,9 @@ static void zram_free_page(struct zram *zram, size_t index)
 		goto out;
 	}
 
-	obj = kmap_atomic(page, KM_USER0) + offset;
+	obj = kmap_atomic(page) + offset;
 	clen = xv_get_object_size(obj) - sizeof(struct zobj_header);
-	kunmap_atomic(obj, KM_USER0);
+	kunmap_atomic(obj);
 
 	xv_free(zram->mem_pool, page, offset);
 	if (clen <= PAGE_SIZE / 2)
@@ -182,9 +182,9 @@ static void handle_zero_page(struct bio_vec *bvec)
 	struct page *page = bvec->bv_page;
 	void *user_mem;
 
-	user_mem = kmap_atomic(page, KM_USER0);
+	user_mem = kmap_atomic(page);
 	memset(user_mem + bvec->bv_offset, 0, bvec->bv_len);
-	kunmap_atomic(user_mem, KM_USER0);
+	kunmap_atomic(user_mem);
 
 	flush_dcache_page(page);
 }
@@ -195,12 +195,12 @@ static void handle_uncompressed_page(struct zram *zram, struct bio_vec *bvec,
 	struct page *page = bvec->bv_page;
 	unsigned char *user_mem, *cmem;
 
-	user_mem = kmap_atomic(page, KM_USER0);
-	cmem = kmap_atomic(zram->table[index].page, KM_USER1);
+	user_mem = kmap_atomic(page);
+	cmem = kmap_atomic(zram->table[index].page);
 
 	memcpy(user_mem + bvec->bv_offset, cmem + offset, bvec->bv_len);
-	kunmap_atomic(cmem, KM_USER1);
-	kunmap_atomic(user_mem, KM_USER0);
+	kunmap_atomic(cmem);
+	kunmap_atomic(user_mem);
 
 	flush_dcache_page(page);
 }
@@ -249,12 +249,12 @@ static int zram_bvec_read(struct zram *zram, struct bio_vec *bvec,
 		}
 	}
 
-	user_mem = kmap_atomic(page, KM_USER0);
+	user_mem = kmap_atomic(page);
 	if (!is_partial_io(bvec))
 		uncmem = user_mem;
 	clen = PAGE_SIZE;
 
-	cmem = kmap_atomic(zram->table[index].page, KM_USER1) +
+	cmem = kmap_atomic(zram->table[index].page) +
 		zram->table[index].offset;
 
 	ret = lzo1x_decompress_safe(cmem + sizeof(*zheader),
@@ -267,8 +267,8 @@ static int zram_bvec_read(struct zram *zram, struct bio_vec *bvec,
 		kfree(uncmem);
 	}
 
-	kunmap_atomic(cmem, KM_USER1);
-	kunmap_atomic(user_mem, KM_USER0);
+	kunmap_atomic(cmem);
+	kunmap_atomic(user_mem);
 
 	/* Should NEVER happen. Return bio error if it does. */
 	if (unlikely(ret != LZO_E_OK)) {
@@ -295,20 +295,20 @@ static int zram_read_before_write(struct zram *zram, char *mem, u32 index)
 		return 0;
 	}
 
-	cmem = kmap_atomic(zram->table[index].page, KM_USER0) +
+	cmem = kmap_atomic(zram->table[index].page) +
 		zram->table[index].offset;
 
 	/* Page is stored uncompressed since it's incompressible */
 	if (unlikely(zram_test_flag(zram, index, ZRAM_UNCOMPRESSED))) {
 		memcpy(mem, cmem, PAGE_SIZE);
-		kunmap_atomic(cmem, KM_USER0);
+		kunmap_atomic(cmem);
 		return 0;
 	}
 
 	ret = lzo1x_decompress_safe(cmem + sizeof(*zheader),
 				    xv_get_object_size(cmem) - sizeof(*zheader),
 				    mem, &clen);
-	kunmap_atomic(cmem, KM_USER0);
+	kunmap_atomic(cmem);
 
 	/* Should NEVER happen. Return bio error if it does. */
 	if (unlikely(ret != LZO_E_OK)) {
@@ -359,7 +359,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 	    zram_test_flag(zram, index, ZRAM_ZERO))
 		zram_free_page(zram, index);
 
-	user_mem = kmap_atomic(page, KM_USER0);
+	user_mem = kmap_atomic(page);
 
 	if (is_partial_io(bvec))
 		memcpy(uncmem + offset, user_mem + bvec->bv_offset,
@@ -368,7 +368,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 		uncmem = user_mem;
 
 	if (page_zero_filled(uncmem)) {
-		kunmap_atomic(user_mem, KM_USER0);
+		kunmap_atomic(user_mem);
 		if (is_partial_io(bvec))
 			kfree(uncmem);
 		zram_stat_inc(&zram->stats.pages_zero);
@@ -380,7 +380,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 	ret = lzo1x_1_compress(uncmem, PAGE_SIZE, src, &clen,
 			       zram->compress_workmem);
 
-	kunmap_atomic(user_mem, KM_USER0);
+	kunmap_atomic(user_mem);
 	if (is_partial_io(bvec))
 			kfree(uncmem);
 
@@ -408,7 +408,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 		zram_set_flag(zram, index, ZRAM_UNCOMPRESSED);
 		zram_stat_inc(&zram->stats.pages_expand);
 		zram->table[index].page = page_store;
-		src = kmap_atomic(page, KM_USER0);
+		src = kmap_atomic(page);
 		goto memstore;
 	}
 
@@ -424,7 +424,7 @@ static int zram_bvec_write(struct zram *zram, struct bio_vec *bvec, u32 index,
 memstore:
 	zram->table[index].offset = store_offset;
 
-	cmem = kmap_atomic(zram->table[index].page, KM_USER1) +
+	cmem = kmap_atomic(zram->table[index].page) +
 		zram->table[index].offset;
 
 #if 0
@@ -438,9 +438,9 @@ memstore:
 
 	memcpy(cmem, src, clen);
 
-	kunmap_atomic(cmem, KM_USER1);
+	kunmap_atomic(cmem);
 	if (unlikely(zram_test_flag(zram, index, ZRAM_UNCOMPRESSED)))
-		kunmap_atomic(src, KM_USER0);
+		kunmap_atomic(src);
 
 	/* Update stats */
 	zram_stat64_add(zram, &zram->stats.compr_size, clen);
-- 
1.7.4.4


  parent reply	other threads:[~2011-11-27  5:33 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-27  5:26 [V2 PATCH 00/62] highmem: remove the second argument of kmap_atomic/kunmap_atomic Cong Wang
2011-11-27  5:26 ` [PATCH 01/62] highmem: mark k[un]map_atomic() with two arguments as deprecated Cong Wang
2011-11-27 12:34   ` Cesar Eduardo Barros
2011-11-28  5:07     ` Cong Wang
2011-11-28  7:46   ` [UPDATED PATCH " Cong Wang
2011-11-27  5:26 ` [PATCH 02/62] include/linux/highmem.h: remove the second argument of k[un]map_atomic() Cong Wang
2011-11-27  5:26 ` [PATCH 03/62] arm: " Cong Wang
2011-12-10 21:46   ` Russell King - ARM Linux
2011-11-27  5:26 ` [PATCH 04/62] mips: " Cong Wang
2011-12-09 16:06   ` Ralf Baechle
2011-12-12  2:52     ` Cong Wang
2011-11-27  5:26 ` [PATCH 05/62] powerpc: " Cong Wang
2011-11-27  5:26 ` [PATCH 06/62] sh: " Cong Wang
2011-11-27  5:26 ` [PATCH 07/62] um: " Cong Wang
2011-11-27  5:26 ` [PATCH 08/62] x86: " Cong Wang
2011-11-28 12:35   ` Avi Kivity
2011-11-28 12:47   ` Herbert Xu
2011-11-27  5:26 ` [PATCH 09/62] crypto: " Cong Wang
2011-11-27  5:26 ` [PATCH 10/62] ata: " Cong Wang
2011-11-27 18:40   ` Jeff Garzik
2011-11-28 10:01   ` Sergei Shtylyov
2011-11-28 11:42     ` Cong Wang
2011-11-28 11:49       ` Cong Wang
2011-11-28 19:00         ` James Bottomley
2011-11-29  3:25           ` Cong Wang
2011-11-27  5:26 ` [PATCH 11/62] block: " Cong Wang
2011-11-27  5:26 ` [PATCH 12/62] crypto: " Cong Wang
2011-11-27  5:26 ` [PATCH 13/62] edac: " Cong Wang
2011-11-27  5:26 ` [PATCH 14/62] drm: " Cong Wang
2011-11-27  5:26 ` [PATCH 15/62] ide: " Cong Wang
2011-11-27  6:12   ` David Miller
2011-11-27  5:26 ` [PATCH 16/62] infiniband: " Cong Wang
2011-11-28  7:38   ` Roland Dreier
2011-11-28  7:45     ` Cong Wang
2011-11-27  5:26 ` [PATCH 17/62] md: " Cong Wang
2011-11-27  6:00   ` NeilBrown
2011-11-27 10:27     ` [dm-devel] " Milan Broz
2011-11-28  5:10       ` Cong Wang
2011-11-28  7:47     ` [UPDATED PATCH " Cong Wang
2011-11-27  5:26 ` [PATCH 18/62] media: " Cong Wang
2011-11-27 23:10   ` Andy Walls
2011-11-27  5:26 ` [PATCH 19/62] memstick: " Cong Wang
2011-11-27  5:27 ` [PATCH 20/62] mmc: " Cong Wang
2011-11-27 21:02   ` Guennadi Liakhovetski
2011-11-30 23:51   ` David Brown
2011-12-01 18:47   ` Chris Ball
2011-12-02  2:10     ` Cong Wang
2011-11-27  5:27 ` [PATCH 21/62] net: " Cong Wang
2011-11-27  6:12   ` David Miller
2011-11-27  8:07   ` Eric Dumazet
2011-11-28 18:06     ` Alexander Duyck
2011-11-28 18:26       ` Eric Dumazet
2011-11-28  7:39   ` Cong Wang
2011-11-28  7:48   ` [UPDATED PATCH " Cong Wang
2011-11-27  5:27 ` [PATCH 23/62] hv: " Cong Wang
2011-11-27  9:34   ` Greg KH
2011-11-27  5:27 ` [PATCH 24/62] pohmelfs: " Cong Wang
2011-11-27  9:34   ` Greg KH
2011-11-28  0:58     ` Evgeniy Polyakov
2011-11-27  5:27 ` [PATCH 25/62] rtl8192u: " Cong Wang
2011-11-27  9:34   ` Greg KH
2011-11-27  5:27 ` Cong Wang [this message]
2011-11-27  9:34   ` [PATCH 26/62] zram: " Greg KH
2011-11-27  5:27 ` [PATCH 27/62] target: " Cong Wang
2011-11-27  5:27 ` [PATCH 28/62] vhost: " Cong Wang
2011-11-27  5:27 ` [PATCH 29/62] fs: " Cong Wang
2011-11-28  2:36   ` Benjamin LaHaise
2011-11-27  5:27 ` [PATCH 30/62] btrfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 31/62] ecryptfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 32/62] afs: " Cong Wang
2011-11-27  5:27 ` [PATCH 33/62] exofs: " Cong Wang
2011-11-28 17:35   ` Boaz Harrosh
2011-11-27  5:27 ` [PATCH 34/62] ext2: " Cong Wang
2011-11-28 14:15   ` Jan Kara
2011-11-27  5:27 ` [PATCH 35/62] fuse: " Cong Wang
2011-11-27  5:27 ` [PATCH 36/62] gfs2: " Cong Wang
2011-11-27  5:27 ` [PATCH 37/62] jbd: " Cong Wang
2011-11-28 14:15   ` Jan Kara
2011-11-27  5:27 ` [PATCH 38/62] jbd2: " Cong Wang
2011-11-27  5:27 ` [PATCH 39/62] logfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 40/62] minix: " Cong Wang
2011-11-27  5:27 ` [PATCH 41/62] nfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 42/62] nilfs2: " Cong Wang
2011-11-28 16:14   ` Ryusuke Konishi
2011-11-27  5:27 ` [PATCH 43/62] ntfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 44/62] ocfs2: " Cong Wang
2011-12-01 20:18   ` Joel Becker
2011-12-02  2:04     ` Cong Wang
2011-12-02  2:29       ` Andrew Morton
2011-12-02  2:38         ` Cong Wang
2011-11-27  5:27 ` [PATCH 45/62] reiserfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 46/62] squashfs: " Cong Wang
2011-11-27  5:27 ` [PATCH 47/62] ubifs: " Cong Wang
2011-11-27  5:27 ` [PATCH 48/62] udf: " Cong Wang
2011-11-28 14:16   ` Jan Kara
2011-11-27  5:27 ` [PATCH 49/62] kdb: " Cong Wang
2011-11-27  5:27 ` [PATCH 50/62] power: " Cong Wang
2011-11-27 11:38   ` Rafael J. Wysocki
2011-11-27  5:27 ` [PATCH 51/62] lib: " Cong Wang
2011-11-27  5:27 ` [PATCH 52/62] mm: " Cong Wang
2011-11-27  5:27 ` [PATCH 53/62] net: " Cong Wang
2011-11-27  6:12   ` David Miller
2011-11-27  5:27 ` [PATCH 54/62] rds: " Cong Wang
2011-11-27  6:13   ` David Miller
2011-11-27  5:27 ` [PATCH 55/62] sunrpc: " Cong Wang
2011-11-27  5:27 ` [PATCH 56/62] tomoyo: " Cong Wang
2011-11-27  5:27 ` [PATCH 57/62] md: " Cong Wang
2011-11-28  7:50   ` [UPDATED PATCH 57/62] dm: " Cong Wang
2011-11-27  5:27 ` [PATCH 58/62] gma500: " Cong Wang
2011-11-28 11:33   ` Alan Cox
2011-11-27  5:27 ` [PATCH 59/62] zcache: " Cong Wang
2011-11-27  9:34   ` Greg KH
2011-11-27  5:27 ` [PATCH 60/62] drbd: " Cong Wang
2011-11-27  5:27 ` [PATCH 61/62] highmem: kill all __kmap_atomic() Cong Wang
2011-12-09 16:07   ` Ralf Baechle
2011-11-27  5:27 ` [PATCH 62/62] feature-removal-schedule.txt: add the deprecated form of kmap_atomic() Cong Wang
2011-11-27 22:21 ` [V2 PATCH 00/62] highmem: remove the second argument of kmap_atomic/kunmap_atomic Benjamin Herrenschmidt
2011-11-28  4:34   ` Benjamin Herrenschmidt
2011-11-28  5:34     ` Cong Wang
2011-11-28  7:42   ` Cong Wang
2011-11-29  3:36 ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322371662-26166-27-git-send-email-amwang@redhat.com \
    --to=amwang@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@suse.de \
    --cc=jmarchan@redhat.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=penberg@kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=rcj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®