From: Christoph Fritz <chf.fritz@googlemail.com>
To: Mike Waychison <mikew@google.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Tony Luck <tony.luck@intel.com>, Matthew Garrett <mjg@redhat.com>,
Dan Carpenter <error27@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] efivars: add missing parameter to efi_pstore_read()
Date: Mon, 28 Nov 2011 23:49:33 +0100 [thread overview]
Message-ID: <1322520574.24241.10.camel@mars> (raw)
In the case where CONFIG_PSTORE=n, the function efi_pstore_read() doesn't
have the correct list of parameters. This patch provides a definition
of efi_pstore_read() with 'char **buf' added to fix this warning:
"drivers/firmware/efivars.c:609: warning: initialization from".
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
---
drivers/firmware/efivars.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
index a54a6b9..b0a8117 100644
--- a/drivers/firmware/efivars.c
+++ b/drivers/firmware/efivars.c
@@ -581,7 +581,8 @@ static int efi_pstore_close(struct pstore_info *psi)
}
static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type,
- struct timespec *time, struct pstore_info *psi)
+ struct timespec *timespec,
+ char **buf, struct pstore_info *psi)
{
return -1;
}
--
1.7.2.5
next reply other threads:[~2011-11-28 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 22:49 Christoph Fritz [this message]
2011-11-28 23:41 ` Tony Luck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322520574.24241.10.camel@mars \
--to=chf.fritz@googlemail.com \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg@redhat.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®