From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756547Ab1K2XLV (ORCPT ); Tue, 29 Nov 2011 18:11:21 -0500 Received: from mail-out1.uio.no ([129.240.10.57]:40446 "EHLO mail-out1.uio.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756425Ab1K2XLT (ORCPT ); Tue, 29 Nov 2011 18:11:19 -0500 X-Greylist: delayed 1941 seconds by postgrey-1.27 at vger.kernel.org; Tue, 29 Nov 2011 18:11:18 EST Message-ID: <1322606322.11286.30.camel@lade.trondhjem.org> Subject: Re: ore: FIX breakage when MISC_FILESYSTEMS is not set From: Trond Myklebust To: Boaz Harrosh Cc: Benny Halevy , Randy Dunlap , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Michal Marek , NFS list , open-osd Date: Tue, 29 Nov 2011 17:38:42 -0500 In-Reply-To: <1322606193.11286.28.camel@lade.trondhjem.org> References: <20111124174358.d88f11c0ff700e5e6b3bf73b@canb.auug.org.au> <4ECE91F3.9010007@xenotime.net> <4ED422CC.60706@panasas.com> <4ED4238F.4090407@panasas.com> <4ED4CE58.8090107@tonian.com> <1322588023.4174.28.camel@lade.trondhjem.org> <4ED55B3B.9050207@panasas.com> <1322606193.11286.28.camel@lade.trondhjem.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2 (3.2.2-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-UiO-Ratelimit-Test: rcpts/h 9 msgs/h 1 sum rcpts/h 9 sum msgs/h 1 total rcpts 1556 max rcpts/h 20 ratelimit 0 X-UiO-Spam-info: not spam, SpamAssassin (score=-5.0, required=5.0, autolearn=disabled, UIO_MAIL_IS_INTERNAL=-5, uiobl=NO, uiouri=NO) X-UiO-Scanned: 833FB9FB2B823E86972D5DDB1DCCF7B61C90C837 X-UiO-SPAM-Test: remote_host: 98.250.106.145 spam_score: -49 maxlevel 80 minaction 2 bait 0 mail/h: 1 total 25 max/h 3 blacklist 0 greylist 0 ratelimit 0 X-UiOonly: 4A0A5FA02B86284CFE4502B906A87ECE7385672B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-11-29 at 17:36 -0500, Trond Myklebust wrote: > On Tue, 2011-11-29 at 14:22 -0800, Boaz Harrosh wrote: > > On 11/29/2011 09:33 AM, Trond Myklebust wrote: > > > On Tue, 2011-11-29 at 14:21 +0200, Benny Halevy wrote: > > >> On 2011-11-29 02:13, Boaz Harrosh wrote: > > > > >>> > > >>> The solution is to force all users of ORE (exofs, nfs) to manually > > >>> select everything auto-magically selected before. > > >> > > >> How about using "depend ORE" rather than "select ORE"? > > > > > > Right. Make PNFS_OBJLAYOUT and EXOFS_FS depend on ASYNC_XOR (or select > > > it) and then make ORE depend on EXOFS_FS || PNFS_OBJLAYOUT. > > > > > > There should be no need to add the 'select ORE'... > > > > > > > No! guys! > > > > One it will not solve my problem because any > > solution that needs to inspect exofs/Kconfig file will > > not work if MISC_FILESYSTEMS is not selected and your > > solutions involve that. > > Then move ORE _out_ of MISC_FILESYSTEMS. There is no reason why it needs > to be there as long as the things it depends on are there. Should read: There is no reason why ORE needs to depend on MISC_FILESYSTEMS. Only EXOFS_FS needs that... > > And two: > > All the user needs to do is Select NFS4.1 everything > > else should be done automatically. He should not need > > to go to misc-filesystems and select ORE so he can have > > pnfs-objects. That's a nightmare. > > The solution I proposed didn't involve having the user select anything > other than NFSv4.1 and possibly ASYNC_XOR. > > > And anyway the current Kernel rule is that a user of a library > > needs to select it and all it's dependencies, because select > > is not recursive. Now I devised a little skim that can avoid > > ...and this is _my_ nightmare. I dont' _want_ these selects anywhere in > the NFS subsystem.