From: Andy Whitcroft <apw@canonical.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: [PATCH 1/2] checkpatch: fix up complex macros context format
Date: Thu, 1 Dec 2011 09:33:00 +0000 [thread overview]
Message-ID: <1322731981-22130-1-git-send-email-apw@canonical.com> (raw)
Fix a missing newline and correctly use the raw context for the
complex macro report.
Signed-off-by: Andy Whitcroft <apw@canonical.com>
---
scripts/checkpatch.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This could be considered to be a fix for:
checkpatch-correctly-track-the-end-of-preprocessor-commands-in-context.patch
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e29eeea..331e832 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2854,7 +2854,7 @@ sub process {
"Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
} else {
ERROR("COMPLEX_MACRO",
- "Macros with complex values should be enclosed in parenthesis\n" . "$here$ctx");
+ "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
}
}
}
--
1.7.5.4
next reply other threads:[~2011-12-01 9:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 9:33 Andy Whitcroft [this message]
2011-12-01 9:33 ` [PATCH 2/2] checkpatch: catch all occurances of type and cast spacing errors per line Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322731981-22130-1-git-send-email-apw@canonical.com \
--to=apw@canonical.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®