mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: "Sjur Brændeland" <sjur.brandeland@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	sjurbren@gmail.com
Subject: Re: [RFCv2 8/9] xshm: Makefile and Kconfig for M7400 Shared Memory Drivers
Date: Fri, 02 Dec 2011 13:01:36 +0100	[thread overview]
Message-ID: <1322827296.2313.21.camel@x61.thuisdomein> (raw)
In-Reply-To: <1322595550-6473-9-git-send-email-sjur.brandeland@stericsson.com>

Spotted some typos, see below.

On Tue, 2011-11-29 at 20:39 +0100, Sjur Brændeland wrote:
>[...]
> diff --git a/drivers/xshm/Kconfig b/drivers/xshm/Kconfig
> new file mode 100644
> index 0000000..bae0da2
> --- /dev/null
> +++ b/drivers/xshm/Kconfig
> @@ -0,0 +1,17 @@
> +# XSHM gets selected by whoever wants it.
> +config XSHM
> +	depends on CONFIG_C2C
> +	tristate
> +
> +config XSHM_CHR
> +	tristate "Character device for External Shared Memory (XSHM)"
> +	select XSHM
> +	default n
> +	---help---
> +	Say "Y" if you want to character device for External Shared

Perhaps "[...] to use a character device for the [...]"? 

> +	Memory (XSHM) IPC mechanism. XSHM is an IPC protocol used to
> +	talk to external device such as modem over a shared memory
> +	(e.g. Chip to Chip).
> +	Only say "M" here if you want to test XSHM and needs to load

s/needs/need/.

> +	and unload its module.
> +	If unsure say N.
>[...]


Paul Bolle


  reply	other threads:[~2011-12-02 12:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 19:39 [RFCv2 0/9] XSHM: Shared Memory Driver for ST-E Thor M7400 LTE modem Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 1/9] xshm: Shared Memory layout for ST-E M7400 driver Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 2/9] xshm: Channel config definitions " Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 3/9] xshm: Config data use for platform devices Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 4/9] xshm: geni/geno driver interface Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 5/9] xshm: genio dummy driver Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 6/9] xshm: Platform device for XSHM Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 7/9] xshm: Character device for XSHM channel access Sjur Brændeland
2011-11-29 19:39 ` [RFCv2 8/9] xshm: Makefile and Kconfig for M7400 Shared Memory Drivers Sjur Brændeland
2011-12-02 12:01   ` Paul Bolle [this message]
2011-12-05  9:37     ` Sjur BRENDELAND
2011-11-29 19:39 ` [RFCv2 9/9] caif-xshm: Add CAIF driver for Shared memory for M7400 Sjur Brændeland
2011-11-29 19:47   ` David Miller
2011-12-02 11:50   ` Paul Bolle
2011-12-05  9:43     ` Sjur BRENDELAND

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322827296.2313.21.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjur.brandeland@stericsson.com \
    --cc=sjurbren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®