mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namjae Jeon <linkinjeon@gmail.com>
To: akpm@linux-foundation.org
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
	Namjae Jeon <linkinjeon@gmail.com>,
	Ashish Sangwan <ashishsangwan2@gmail.com>
Subject: [PATCH] nls: add surrogate pair support in nls utf8.
Date: Sun,  4 Dec 2011 06:17:34 -0500	[thread overview]
Message-ID: <1322997454-22955-1-git-send-email-linkinjeon@gmail.com> (raw)

It allows surrogate pair in nls utf8.

Signed-off-by: Ashish Sangwan <ashishsangwan2@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
CC: Alan Stern <stern@rowland.harvard.edu>
---
 fs/nls/nls_base.c   |    8 --------
 fs/nls/nls_utf8.c   |   15 +++++++++++++--
 include/linux/nls.h |    8 ++++++++
 3 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/fs/nls/nls_base.c b/fs/nls/nls_base.c
index 44a88a9..07a12cc 100644
--- a/fs/nls/nls_base.c
+++ b/fs/nls/nls_base.c
@@ -44,14 +44,6 @@ static const struct utf8_table utf8_table[] =
     {0,						       /* end of table    */}
 };
 
-#define UNICODE_MAX	0x0010ffff
-#define PLANE_SIZE	0x00010000
-
-#define SURROGATE_MASK	0xfffff800
-#define SURROGATE_PAIR	0x0000d800
-#define SURROGATE_LOW	0x00000400
-#define SURROGATE_BITS	0x000003ff
-
 int utf8_to_utf32(const u8 *s, int len, unicode_t *pu)
 {
 	unsigned long l;
diff --git a/fs/nls/nls_utf8.c b/fs/nls/nls_utf8.c
index 0d60a44..be7685a 100644
--- a/fs/nls/nls_utf8.c
+++ b/fs/nls/nls_utf8.c
@@ -30,13 +30,24 @@ static int char2uni(const unsigned char *rawstring, int boundlen, wchar_t *uni)
 {
 	int n;
 	unicode_t u;
+	u16 *op;
 
+	op = uni;
 	n = utf8_to_utf32(rawstring, boundlen, &u);
-	if (n < 0 || u > MAX_WCHAR_T) {
+	if (n < 0 || u > UNICODE_MAX) {
 		*uni = 0x003f;	/* ? */
 		return -EINVAL;
 	}
-	*uni = (wchar_t) u;
+
+	if (u >= PLANE_SIZE) {
+		u -= PLANE_SIZE;
+		*op++ = (wchar_t) (SURROGATE_PAIR |
+		((u >> 10) & SURROGATE_BITS));
+		*op++ = (wchar_t) (SURROGATE_PAIR |
+		SURROGATE_LOW | (u & SURROGATE_BITS));
+		} else
+			*op++ = (wchar_t) u;
+
 	return n;
 }
 
diff --git a/include/linux/nls.h b/include/linux/nls.h
index d47beef..253cbd2 100644
--- a/include/linux/nls.h
+++ b/include/linux/nls.h
@@ -18,6 +18,14 @@
 typedef u16 wchar_t;
 #define MAX_WCHAR_T	0xffff
 
+/* Plane-1 Unicode surrogate pair characters */
+#define UNICODE_MAX	0x0010ffff
+#define PLANE_SIZE	0x00010000
+#define SURROGATE_MASK	0xfffff800
+#define SURROGATE_PAIR	0x0000d800
+#define SURROGATE_LOW	0x00000400
+#define SURROGATE_BITS	0x000003ff
+
 /* Arbitrary Unicode character */
 typedef u32 unicode_t;
 
-- 
1.7.5.4


             reply	other threads:[~2011-12-04 11:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-04 11:17 Namjae Jeon [this message]
2011-12-04 17:08 ` Alan Stern
2011-12-05 23:41   ` Namjae Jeon
2011-12-06 16:10     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322997454-22955-1-git-send-email-linkinjeon@gmail.com \
    --to=linkinjeon@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=ashishsangwan2@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®