From: John Stultz <john.stultz@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Richard Cochran <richard.cochran@omicron.at>
Subject: Re: [PTP] Implement clock_getres() function correctly
Date: Mon, 05 Dec 2011 11:02:41 -0800 [thread overview]
Message-ID: <1323111761.21423.229.camel@work-vm> (raw)
In-Reply-To: <alpine.LFD.2.02.1112041806550.2735@ionos>
On Sun, 2011-12-04 at 18:07 +0100, Thomas Gleixner wrote:
> On Sun, 4 Dec 2011, Thomas Gleixner wrote:
>
> > clock_getres() needs to put the resolution into the provided timespec
> > and return 0 in case of success.
> >
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > Cc: stable@vger.kernel.org
>
> Gah, wrong version.
>
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index cf3f999..6b0c02a 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -101,7 +101,10 @@ static s32 scaled_ppm_to_ppb(long ppm)
>
> static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp)
> {
> - return 1; /* always round timer functions to one nanosecond */
> + /* Resolution is one nanosecond */
> + tp->tv_sec = 0;
> + tp->tv_nsec = 1;
> + return 0;
> }
>
> static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp)
Looks good.
Acked-by: John Stultz <john.stultz@linaro.org>
prev parent reply other threads:[~2011-12-05 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 17:06 Thomas Gleixner
2011-12-04 17:07 ` Thomas Gleixner
2011-12-05 7:31 ` Richard Cochran
2011-12-05 19:02 ` John Stultz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323111761.21423.229.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.cochran@omicron.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®