From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754999Ab1LGCwO (ORCPT ); Tue, 6 Dec 2011 21:52:14 -0500 Received: from mail-ee0-f74.google.com ([74.125.83.74]:62704 "EHLO mail-ee0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988Ab1LGCwN (ORCPT ); Tue, 6 Dec 2011 21:52:13 -0500 X-Greylist: delayed 484 seconds by postgrey-1.27 at vger.kernel.org; Tue, 06 Dec 2011 21:52:13 EST From: Mandeep Singh Baines To: Thomas Gleixner , linux-kernel@vger.kernel.org Cc: Mandeep Singh Baines , Thomas Gleixner , Pavel Emelyanov , Oleg Nesterov , Andrew Morton , Kees Cook Subject: [PATCH] sys_getppid: add missing rcu_dereference Date: Tue, 6 Dec 2011 18:43:54 -0800 Message-Id: <1323225834-23765-1-git-send-email-msb@chromium.org> X-Mailer: git-send-email 1.7.3.1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to safely dereference current->real_parent inside an rcu_read_lock, we need an rcu_dereference. Signed-off-by: Mandeep Singh Baines Cc: Thomas Gleixner Cc: Pavel Emelyanov Cc: Oleg Nesterov Cc: Andrew Morton Cc: Kees Cook --- kernel/timer.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/timer.c b/kernel/timer.c index dbaa624..9c3c62b 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1368,7 +1368,7 @@ SYSCALL_DEFINE0(getppid) int pid; rcu_read_lock(); - pid = task_tgid_vnr(current->real_parent); + pid = task_tgid_vnr(rcu_dereference(current->real_parent)); rcu_read_unlock(); return pid; -- 1.7.3.1