From: Vinod Koul <vinod.koul@intel.com>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: "'Tushar Behera'" <tushar.behera@linaro.org>,
"'Boojin Kim'" <boojin.kim@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-dev@lists.linaro.org, patches@linaro.org
Subject: RE: [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove
Date: Thu, 08 Dec 2011 13:46:45 +0530 [thread overview]
Message-ID: <1323332205.1641.29.camel@vkoul-udesk3> (raw)
In-Reply-To: <002201ccb57d$056d2440$10476cc0$%kim@samsung.com>
On Thu, 2011-12-08 at 16:43 +0900, Kukjin Kim wrote:
> Vinod Koul wrote:
> >
> > On Tue, 2011-12-06 at 16:15 +0530, Tushar Behera wrote:
> > > amba_probe() now calls pm_runtime_get_noresume() and pm_runtime_enable()
> > > for the devices before the device probe is called. Hence we don't need
> > > to call pm_runtime_get_xxx and pm_runtime_enable() in device probe again.
> > > In the same way, since amba_remove() calls the respective pm_runtime
> > > functions, those functions need not be called from device remove.
> > >
> > > This patch fixes following run time error with pl330 driver.
> > >
> > > dma-pl330 dma-pl330.0: Unbalanced pm_runtime_enable!
> > > dma-pl330 dma-pl330.0: failed to get runtime pm
> > >
> > > Signed-off-by: Giridhar Maruthy <giridhar.maruthy@linaro.org>
> > > Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> > Looks fine to me. Do you want these to go thru slave-dma or samsung
> > tree.
>
> Hi Vinod,
>
> I think, this patch can be sent to upstream via slave-dma tree and
> second one via Samsung tree separately and you can add my and Boojin
> Kim's ack(actually, she replied) on this when you apply.
Okay, I have applied this one only
--
~Vinod
next prev parent reply other threads:[~2011-12-08 8:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 10:45 [PATCH 0/2] Add PM_RUNTIME related fixes for PL330 Tushar Behera
2011-12-06 10:45 ` [PATCH 1/2] DMA: PL330: Remove pm_runtime_xxx calls from pl330 probe/remove Tushar Behera
2011-12-08 7:35 ` Vinod Koul
2011-12-08 7:43 ` Kukjin Kim
2011-12-08 8:16 ` Vinod Koul [this message]
2011-12-08 13:32 ` Jassi Brar
2011-12-09 3:19 ` Tushar Behera
2011-12-09 3:51 ` Jassi Brar
2011-12-06 10:45 ` [PATCH 2/2] ARM: EXYNOS: Add apb_pclk clkdev entry for mdma1 Tushar Behera
2011-12-08 7:43 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323332205.1641.29.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=boojin.kim@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®