mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Bastian Blank <waldi@debian.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [PATCH 1/4] xen: Add privcmd device driver
Date: Thu, 8 Dec 2011 08:19:45 +0000	[thread overview]
Message-ID: <1323332385.2969.46.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1323292396-19523-2-git-send-email-waldi@debian.org>

On Wed, 2011-12-07 at 21:13 +0000, Bastian Blank wrote:
> +static int __init privcmd_init(void)
> +{
> +       int err;
> +
> +       if (!xen_domain())
> +               return -ENODEV;
> +
> +       err = misc_register(&privcmd_dev);
> +       if (err != 0) {
> +               printk(KERN_ERR "Could not register privcmd device\n"); 

Should say "...register Xen privcmd device". Otherwise:

Acked-by: Ian Campbell <ian.campbell@citrix.com>




  reply	other threads:[~2011-12-08  8:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-07 21:13 [PATCH 0/4] V2, Move stuff out of xenfs Bastian Blank
2011-12-07 21:13 ` [PATCH 1/4] xen: Add privcmd device driver Bastian Blank
2011-12-08  8:19   ` Ian Campbell [this message]
2011-12-07 21:13 ` [PATCH 2/4] xen: Add xenbus " Bastian Blank
2011-12-08  8:20   ` [Xen-devel] " Ian Campbell
2011-12-07 21:13 ` [PATCH 3/4] xen: Add xenbusd " Bastian Blank
2011-12-08  8:24   ` [Xen-devel] " Ian Campbell
2011-12-08  9:27     ` Bastian Blank
2011-12-08  9:32       ` Ian Campbell
2011-12-08 11:08       ` Bastian Blank
2011-12-07 21:13 ` [PATCH 4/4] xen/privcmd: Remove unused support for arch specific privcmp mmap Bastian Blank
2011-12-08  8:32   ` [Xen-devel] " Ian Campbell
2011-12-08  8:34 ` [Xen-devel] [PATCH 0/4] V2, Move stuff out of xenfs Ian Campbell
2011-12-08  9:28   ` Bastian Blank
2011-12-08 11:10     ` David Vrabel
2011-12-10 16:08       ` Bastian Blank
2011-12-08 11:09 ` David Vrabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323332385.2969.46.camel@zakaz.uk.xensource.com \
    --to=ian.campbell@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=waldi@debian.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®