From: Ian Campbell <Ian.Campbell@citrix.com>
To: ANNIE LI <annie.li@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"jeremy@goop.org" <jeremy@goop.org>,
Paul Durrant <Paul.Durrant@citrix.com>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>
Subject: Re: [PATCH V3 1/2] xen/granttable: Support sub-page grants
Date: Mon, 12 Dec 2011 07:10:33 +0000 [thread overview]
Message-ID: <1323673833.20936.65.camel@dagon.hellion.org.uk> (raw)
In-Reply-To: <4EE57204.4030509@oracle.com>
On Mon, 2011-12-12 at 03:16 +0000, ANNIE LI wrote:
> > Please can you name the arguments here and then refer to them by name in
> > the comments instead of all this "First parameter", "second one" stuff.
> >
> > Similarly for the existing comments sorry I didn't notice this in
> > previous review.
> Please check following comments in gnttab_ops, I changed the "First
> parameter", "second one" into parameter name. However, it looks not very
> consistent with parameters format of function fn since only parameter
> type exists, not name.
You can give the parameters names in the function pointers too, that's
what I was suggesting.
e.g.:
int (*map_frames)(unsigned long *frames, unsigned int nr);
Ian.
next prev parent reply other threads:[~2011-12-12 7:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 11:32 [PATCH V3 0/2] xen: patches for supporting sub-page and transitive grants annie.li
2011-12-09 11:32 ` [PATCH V3 1/2] xen/granttable: Support sub-page grants annie.li
2011-12-09 17:38 ` Ian Campbell
2011-12-11 6:05 ` ANNIE LI
2011-12-12 3:16 ` ANNIE LI
2011-12-12 7:10 ` Ian Campbell [this message]
2011-12-12 7:32 ` ANNIE LI
2011-12-09 11:33 ` [PATCH V3 2/2] xen/granttable: Support transitive grants annie.li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323673833.20936.65.camel@dagon.hellion.org.uk \
--to=ian.campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome