From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Pekka Enberg <penberg@kernel.org>, Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: [PATCH 09/11] kvm tools: narrow the C.S. of compat_mtx
Date: Mon, 12 Dec 2011 15:15:53 +0800 [thread overview]
Message-ID: <1323674155-17570-10-git-send-email-laijs@cn.fujitsu.com> (raw)
In-Reply-To: <1323674155-17570-1-git-send-email-laijs@cn.fujitsu.com>
The allocation and the copy are not required in the C.S.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
tools/kvm/guest_compat.c | 15 ++++++---------
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/tools/kvm/guest_compat.c b/tools/kvm/guest_compat.c
index fac53f5..de97df5 100644
--- a/tools/kvm/guest_compat.c
+++ b/tools/kvm/guest_compat.c
@@ -21,20 +21,19 @@ int compat__add_message(const char *title, const char *desc)
{
struct compat_message *msg;
- mutex_lock(&compat_mtx);
msg = malloc(sizeof(*msg));
if (msg == NULL)
goto cleanup;
- *msg = (struct compat_message) {
- .id = id,
- .title = strdup(title),
- .desc = strdup(desc),
- };
+ msg->title = strdup(title);
+ msg->desc = strdup(desc);
if (msg->title == NULL || msg->desc == NULL)
goto cleanup;
+ mutex_lock(&compat_mtx);
+
+ msg->id = id;
list_add_tail(&msg->list, &messages);
mutex_unlock(&compat_mtx);
@@ -48,8 +47,6 @@ cleanup:
free(msg);
}
- mutex_unlock(&compat_mtx);
-
return -ENOMEM;
}
@@ -101,4 +98,4 @@ int compat__print_all_messages(void)
mutex_unlock(&compat_mtx);
return 0;
-}
\ No newline at end of file
+}
--
1.7.4.4
next prev parent reply other threads:[~2011-12-12 7:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 7:15 [PATCH 00/11] kvm tools: cleanups Lai Jiangshan
2011-12-12 7:15 ` [PATCH 01/11] kvm tools: check condition before wait Lai Jiangshan
2011-12-12 7:15 ` [PATCH 02/11] kvm tools: fix function name Lai Jiangshan
2011-12-12 7:15 ` [PATCH 03/11] kvm tools: move threadpool.c to util/ Lai Jiangshan
2011-12-12 7:15 ` [PATCH 04/11] kvm tools: move rbtree.o " Lai Jiangshan
2011-12-12 7:15 ` [PATCH 05/11] kvm tools: add missing build output Lai Jiangshan
2011-12-12 7:15 ` [PATCH 06/11] kvm tools: move read-write.c to util/ Lai Jiangshan
2011-12-12 7:15 ` [PATCH 07/11] kvm tools: move util.c " Lai Jiangshan
2011-12-12 7:15 ` [PATCH 08/11] kvm tools: move strlcat() to util/strbuf.c Lai Jiangshan
2011-12-12 7:15 ` Lai Jiangshan [this message]
2011-12-12 7:15 ` [PATCH 10/11] kvm tools: protect shared global id in compat_mtx C.S Lai Jiangshan
2011-12-12 7:15 ` [PATCH 11/11] kvm tools: remove duplicated code Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323674155-17570-10-git-send-email-laijs@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®