From: Ian Campbell <Ian.Campbell@citrix.com>
To: Bastian Blank <waldi@debian.org>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] [PATCH 6/6] xen/xenbus-backend: Only register device if communication ring is local
Date: Mon, 12 Dec 2011 09:30:33 +0000 [thread overview]
Message-ID: <1323682233.20077.100.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <1323541791-18006-7-git-send-email-waldi@debian.org>
On Sat, 2011-12-10 at 18:29 +0000, Bastian Blank wrote:
> +/* A flag to determine if xenstored is 'local' */
> +#ifdef CONFIG_XEN_BACKEND
> +static int xenstored_local;
> +#endif
I think this can be __initdata since all the users are __init.
> +#ifdef CONFIG_XEN_BACKEND
> + xenstored_local = 1;
I would push this down into xenstore_local_init() and only set it on
success.
> err = xenstored_local_init();
This is now only called if CONFIG_XEN_BACKEND. You should add a similar
#ifdef around the function definition.
Ian.
> if (err)
> goto out_error;
> +#else
> + BUG();
> +#endif
> }
> xen_store_interface = mfn_to_virt(xen_store_mfn);
> }
next prev parent reply other threads:[~2011-12-12 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 18:29 [PATCH 0/6] V3, Move stuff out of xenfs Bastian Blank
2011-12-10 18:29 ` [PATCH 1/6] xen: Add privcmd device driver Bastian Blank
2011-12-14 18:54 ` Konrad Rzeszutek Wilk
2011-12-10 18:29 ` [PATCH 2/6] xen: Add xenbus " Bastian Blank
2011-12-10 18:29 ` [PATCH 3/6] xen: Add xenbus_backend device Bastian Blank
2011-12-10 18:29 ` [PATCH 4/6] xen/privcmd: Remove unused support for arch specific privcmp mmap Bastian Blank
2011-12-10 18:29 ` [PATCH 5/6] xen/xenbus-frontend: Make error message more clear Bastian Blank
2011-12-12 9:25 ` [Xen-devel] " Ian Campbell
2011-12-10 18:29 ` [PATCH 6/6] xen/xenbus-backend: Only register device if communication ring is local Bastian Blank
2011-12-12 9:30 ` Ian Campbell [this message]
2011-12-12 15:42 ` Konrad Rzeszutek Wilk
2011-12-12 18:28 ` [Xen-devel] " Bastian Blank
2011-12-14 19:22 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323682233.20077.100.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=waldi@debian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®