mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Fleming <matt@console-pimps.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Keith Packard <keithp@keithp.com>,
	linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	Matthew Garrett <mjg@redhat.com>, Zhang Rui <rui.zhang@intel.com>,
	Huang Ying <huang.ying.caritas@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] Revert "x86, efi: Calling __pa() with an ioremap()ed address is invalid"
Date: Mon, 12 Dec 2011 10:01:26 +0000	[thread overview]
Message-ID: <1323684086.3669.16.camel@mfleming-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <CA+55aFydzKrzUaDtBaebjKKO4xVpubfZAXP6oSD-SDuDMq9eGw@mail.gmail.com>

On Sun, 2011-12-11 at 18:59 -0800, Linus Torvalds wrote:
> That said, if you've verified that if fails for you, I guess we should
> revert regardless. Matt, any suggestions for tests to do?

A dmesg from Keith of a working kernel would be good since the most
interesting things are the EFI memory map and the E820 memory map.

At this late -rc stage I agree it makes sense to revert this. The
CONFIG_X86_32 oops that the patch fixes has been around for years and no
one seems to have encountered it (until now), whereas this new
regression is likely to affect many more users.

Looks like there are some macbook memory map funnies that still need to
be addressed...

-- 
Matt Fleming, Intel Open Source Technology Center


  parent reply	other threads:[~2011-12-12 10:01 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  0:12 Keith Packard
2011-12-12  2:59 ` Linus Torvalds
2011-12-12  3:01   ` H. Peter Anvin
2011-12-12  3:11     ` Ingo Molnar
2011-12-12  3:31   ` Keith Packard
2011-12-12  3:32     ` H. Peter Anvin
2011-12-12  3:43       ` Keith Packard
2011-12-12 10:01         ` Matt Fleming
2011-12-12 16:35           ` Keith Packard
2011-12-12 16:50             ` Linus Torvalds
2011-12-12 17:09               ` H. Peter Anvin
2011-12-12 17:21               ` Keith Packard
2011-12-12 17:29                 ` H. Peter Anvin
2011-12-12 17:37                   ` Linus Torvalds
2011-12-15 15:29             ` Matt Fleming
2012-01-16  9:22               ` Matt Fleming
2012-01-16  9:31                 ` Ingo Molnar
2012-01-16  9:49                   ` Matt Fleming
2012-01-16  9:55                     ` Ingo Molnar
2012-01-16 10:16                       ` Matt Fleming
2012-01-16 14:54                         ` [tip:x86/efi] x86/efi: Delete efi_ioremap() and fix CONFIG_X86_32 oops tip-bot for Matt Fleming
2012-02-08 12:46                         ` [PATCH] Revert "x86, efi: Calling __pa() with an ioremap()ed address is invalid" Matt Fleming
2012-02-08 17:15                           ` Keith Packard
2012-02-15 12:13                             ` Matt Fleming
2012-02-17 11:21                               ` Ingo Molnar
2011-12-12 10:01   ` Matt Fleming [this message]
2011-12-12 17:09     ` H. Peter Anvin
2011-12-12 17:26       ` Ingo Molnar
2011-12-12  3:06 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323684086.3669.16.camel@mfleming-mobl1.ger.corp.intel.com \
    --to=matt@console-pimps.org \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=huang.ying.caritas@gmail.com \
    --cc=keithp@keithp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mjg@redhat.com \
    --cc=rui.zhang@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®