From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754236Ab1LLXpT (ORCPT ); Mon, 12 Dec 2011 18:45:19 -0500 Received: from mx2.netapp.com ([216.240.18.37]:10724 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753807Ab1LLXpO convert rfc822-to-8bit (ORCPT ); Mon, 12 Dec 2011 18:45:14 -0500 X-IronPort-AV: E=Sophos;i="4.71,342,1320652800"; d="scan'208";a="606778954" Message-ID: <1323733511.13849.19.camel@lade.trondhjem.org> Subject: Re: ceph, cifs, nfs, fuse: boolean and / or confusion From: Trond Myklebust To: Andrew Morton Cc: roel , LKML , sage@newdream.net, Steve French , linux-cifs@vger.kernel.org, Miklos Szeredi , fuse-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org Date: Mon, 12 Dec 2011 18:45:11 -0500 In-Reply-To: <1323733153.13849.17.camel@lade.trondhjem.org> References: <4EE688FC.8090606@gmail.com> <20111212152856.871a8301.akpm@linux-foundation.org> <1323733153.13849.17.camel@lade.trondhjem.org> Organization: NetApp Inc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.2 (3.2.2-1.fc16) Mime-Version: 1.0 X-OriginalArrivalTime: 12 Dec 2011 23:45:13.0105 (UTC) FILETIME=[1780D010:01CCB928] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-12-12 at 18:39 -0500, Trond Myklebust wrote: > As far as NFS is concerned, it reverts a regression. NFS only used to > run revalidate_file_size() for SEEK_END prior to commit > 06222e491e663dac939f04b125c9dc52126a75c4. I accept that we now also need > to run it for SEEK_HOLE and SEEK_DATA, but we've never had to do so for > SEEK_SET and SEEK_CUR. BTW: The regression exists in 3.1, so this is probably a stable candidate... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com