From: Joe Perches <joe@perches.com>
To: roel <roel.kluin@gmail.com>, Barry Song <baohua.song@csr.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: drivers/dma/sirf-dma.c: boolean and / or confusion
Date: Mon, 12 Dec 2011 16:14:23 -0800 [thread overview]
Message-ID: <1323735263.3837.13.camel@joe2Laptop> (raw)
In-Reply-To: <4EE688FC.8090606@gmail.com>
On Tue, 2011-12-13 at 00:06 +0100, roel wrote:
> The test not [val1] or not [val2] always evaluates to true
Looking at drivers with:
$ grep -rP --include=*.[ch] "(\b[\w\[\]\>\._\-]+)\s*\!\=\s*[\w\[\]\>\._\-]+\s*\)\s*\|\|\s*\(\s*\1\s*\!\=" drivers
drivers/dma/sirf-dma.c: if ((xt->dir != DMA_MEM_TO_DEV) || (xt->dir != DMA_DEV_TO_MEM)) {
Likely the || should be &&
prev parent reply other threads:[~2011-12-13 0:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 23:06 ceph, cifs, nfs, fuse: " roel
2011-12-12 23:28 ` Andrew Morton
2011-12-12 23:39 ` Trond Myklebust
2011-12-12 23:45 ` Trond Myklebust
2011-12-12 23:54 ` Andrew Morton
2011-12-13 5:29 ` Sage Weil
2011-12-13 11:25 ` Miklos Szeredi
2011-12-13 14:34 ` Jeff Layton
2011-12-12 23:44 ` drivers/crypto/picoxcell_crypto.c: " Joe Perches
2011-12-12 23:55 ` drivers/media/video/s5p-fimc/fimc-capture.c: " Joe Perches
2011-12-13 14:26 ` Sylwester Nawrocki
2011-12-13 9:50 ` drivers/crypto/picoxcell_crypto.c: " Jamie Iles
2011-12-13 0:02 ` drivers/scsi/bfa/bfa_fcpim.c: " Joe Perches
2011-12-13 0:45 ` Jing Huang
2011-12-13 0:14 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323735263.3837.13.camel@joe2Laptop \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=baohua.song@csr.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome