From: Afzal Mohammed <afzal@ti.com>
To: <sameo@linux.intel.com>, <broonie@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>
Cc: <nsekhar@ti.com>, Afzal Mohammed <afzal@ti.com>
Subject: [PATCH v2-rebased] mfd: TPS65910: Make usable even if interrupt unused
Date: Tue, 13 Dec 2011 15:27:53 +0530 [thread overview]
Message-ID: <1323770273-21222-1-git-send-email-afzal@ti.com> (raw)
TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about it
Signed-off-by: Afzal Mohammed <afzal@ti.com>
Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
Hi Samuel,
I sent this yesterday, but did not reach LKML,
so assumed you also may not have recieved it;
resending.
Regards
Afzal
drivers/mfd/tps65910.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 6f5b8cf..2fa0178 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -172,15 +172,12 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
- ret = tps65910_irq_init(tps65910, init_data->irq, init_data);
- if (ret < 0)
- goto err;
+ tps65910_irq_init(tps65910, init_data->irq, init_data);
kfree(init_data);
return ret;
err:
- mfd_remove_devices(tps65910->dev);
kfree(tps65910);
kfree(init_data);
return ret;
--
1.7.1
next reply other threads:[~2011-12-13 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 9:57 Afzal Mohammed [this message]
2011-12-13 10:26 ` Marcus Folkesson
2011-12-13 20:49 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323770273-21222-1-git-send-email-afzal@ti.com \
--to=afzal@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®