From: Johannes Berg <johannes@sipsolutions.net>
To: Corentin Chary <corentin.chary@gmail.com>
Cc: Keng-Yu Lin <kengyu@canonical.com>,
Matthew Garrett <mjg@redhat.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] asus-wmi: explicitly set the wireless LED
Date: Thu, 15 Dec 2011 09:26:47 +0100 [thread overview]
Message-ID: <1323937607.3337.6.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <CAHR064ivFUeGwNAfB1MZO0mrvo+sAcM-cZTjR9wZTaPyWRhzAA@mail.gmail.com> (sfid-20111215_092552_215332_009CBEB1)
On Thu, 2011-12-15 at 09:25 +0100, Corentin Chary wrote:
> > static const char *rfkill_ledtrigname(struct rfkill *rfkill)
> > {
> > #ifdef CONFIG_RFKILL_LEDS
> > return rfkill->ledtrigname;
> > #endif
> > return NULL;
> > }
> Right, but is rfkill->ledtrigname really set somewhere ?
>
> rfkill->led_trigger.name seems safer to use.
Hm, indeed -- looks like we can get rid of ledtrigname completely since
nothing ever touches it.
johannes
prev parent reply other threads:[~2011-12-15 8:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 8:02 Keng-Yu Lin
2011-12-15 7:07 ` Corentin Chary
2011-12-15 8:22 ` Johannes Berg
2011-12-15 8:25 ` Corentin Chary
2011-12-15 8:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323937607.3337.6.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=kengyu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®