From: Johannes Berg <johannes@sipsolutions.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Arend van Spriel <arend@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: unexpected taint message
Date: Fri, 16 Dec 2011 15:51:25 +0100 [thread overview]
Message-ID: <1324047085.3429.5.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4EEB5A60.3090101@lwfinger.net> (sfid-20111216_154940_152892_953155B5)
On Fri, 2011-12-16 at 08:49 -0600, Larry Finger wrote:
> > + switch (flag) {
> > + case TAINT_CRAP:
> > + case TAINT_WARN:
> > + case TAINT_OOT_MODULE:
> > + break;
> > + default:
> > + if (__debug_locks_off())
> > + printk(KERN_WARNING
> > + "Disabling lock debugging due to kernel taint\n");
> > + }
> >
> > set_bit(flag,&tainted_mask);
> > }
>
> Yes. I like this patch a lot. Unfortunately, VirtualBox was a part of the
> decision to add the OOT taint. At least for that reason, this patch would not be
> accepted upstream. It is too bad that the Oracle people fought so hard to keep
> their module from setting TAINT_CRAP the way that GregKH wanted. That would have
> had fewer side effects for me.
I'm not sure -- I mean, it's one thing to identify OOT modules and
refuse to support them (and ignore lockdep reports with OOT set), but
it's another to just disable lockdep? I think?
johannes
next prev parent reply other threads:[~2011-12-16 14:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 9:27 Arend van Spriel
2011-12-16 9:29 ` Daniel Baluta
2011-12-16 10:03 ` Arend van Spriel
2011-12-16 12:30 ` Johannes Berg
2011-12-16 13:53 ` Larry Finger
2011-12-16 13:58 ` Johannes Berg
2011-12-16 14:13 ` Larry Finger
2011-12-16 14:20 ` Johannes Berg
2011-12-16 14:49 ` Larry Finger
2011-12-16 14:51 ` Johannes Berg [this message]
2011-12-16 14:48 ` Nick Bowler
2011-12-16 14:57 ` Larry Finger
2011-12-16 14:58 ` Johannes Berg
2011-12-16 14:00 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324047085.3429.5.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=arend@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome