mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Hutchings <ben@decadent.org.uk>
To: linux-kernel@vger.kernel.org
Cc: David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH linux-firmware 3/4] keyspan_pda: Fix parse error with as31 version 2.3.1
Date: Sat, 17 Dec 2011 04:30:39 +0000	[thread overview]
Message-ID: <1324096239.2825.313.camel@deadeye> (raw)
In-Reply-To: <1324096119.2825.310.camel@deadeye>

[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]

keyspan_pda.S has an out-of-range decimal constant that looks
like it was really meant to be a binary constant.  Comparing
with the binary, it appears that as31 used to treat this as 0,
so change the source to use 0 and add a comment on this.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 keyspan_pda/keyspan_pda.S |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/keyspan_pda/keyspan_pda.S b/keyspan_pda/keyspan_pda.S
index 418fe69..602bcce 100644
--- a/keyspan_pda/keyspan_pda.S
+++ b/keyspan_pda/keyspan_pda.S
@@ -285,7 +285,12 @@ clear_rx_ring_loop:
 	mov dptr,OUTC
 	movx @dptr, a
 	;; setup the serial port. 9600 8N1.
-	mov a,#01010011		; mode 1, enable rx, clear int
+	;; Original source had:
+	;;mov a,#01010011		; mode 1, enable rx, clear int
+	;; This was presumably meant to be a binary constant, but it's
+	;; really decimal and out of 8-bit range.  as31 used to treat
+	;; it as 0 and that seems to have worked, so carry on with 0.
+	mov a,#0
 	mov SCON, a
 	;;  using timer2, in 16-bit baud-rate-generator mode
 	;;   (xtal 12MHz, internal fosc 24MHz)
-- 
1.7.7.3




[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

  parent reply	other threads:[~2011-12-17  4:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  4:28 [PATCH linux-firmware 0/4] Complete source for GPL'd firmware Ben Hutchings
2011-12-17  4:29 ` [PATCH linux-firmware 1/4] dsp56k: Add makefile for building from source Ben Hutchings
2011-12-17  4:30 ` [PATCH linux-firmware 2/4] dvb-ttpci: Add source code and makefile Ben Hutchings
2011-12-17  4:30 ` Ben Hutchings [this message]
2011-12-17  4:31 ` [PATCH linux-firmware 4/4] keyspan_pda: Add makefile for building from source Ben Hutchings
2011-12-17  4:33 ` [PATCH linux-firmware 0/4] Complete source for GPL'd firmware Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324096239.2825.313.camel@deadeye \
    --to=ben@decadent.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®