From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Subject: [RFC 2/2] perf: duct tape a crash on perf kvm --guestmount=$(pwd) report
Date: Sat, 17 Dec 2011 14:35:38 +0100 [thread overview]
Message-ID: <1324128938-17553-2-git-send-email-sebastian@breakpoint.cc> (raw)
In-Reply-To: <1324128938-17553-1-git-send-email-sebastian@breakpoint.cc>
Data was collected with
|perf kvm --guestmount=$(pwd) record -a -R -g -s -d -T
After executing
|kvm --guestmount=$(pwd) report
I ended up with two segfaults. This patch duct tapes both of them.
Most likely there is some infomration missing.
Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
---
tools/perf/util/map.c | 2 +-
tools/perf/util/symbol.c | 6 +++++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index 316aa0a..a57f897 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -693,7 +693,7 @@ char *machine__mmap_name(struct machine *self, char *bf, size_t size)
else if (machine__is_default_guest(self))
snprintf(bf, size, "[%s]", "guest.kernel.kallsyms");
else
- snprintf(bf, size, "[%s.%d]", "guest.kernel.kallsyms", self->pid);
+ snprintf(bf, size, "[%s.%d]", "guest.kernel.kallsyms", self ? self->pid : -1);
return bf;
}
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index f2dd916..2760ab1 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1876,8 +1876,12 @@ struct map *machine__new_module(struct machine *machine, u64 start,
const char *filename)
{
struct map *map;
- struct dso *dso = __dsos__findnew(&machine->kernel_dsos, filename);
+ struct dso *dso;
+
+ if (!machine)
+ return NULL;
+ dso = __dsos__findnew(&machine->kernel_dsos, filename);
if (dso == NULL)
return NULL;
--
1.7.7.3
next prev parent reply other threads:[~2011-12-17 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 13:35 [PATCH 1/2] tools/perf: const.h to perf-tar-src-pkg Sebastian Andrzej Siewior
2011-12-17 13:35 ` Sebastian Andrzej Siewior [this message]
2012-01-08 11:50 ` [tip:perf/core] perf tools: Add const. h to MANIFEST to make perf-tar-src-pkg work again tip-bot for Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324128938-17553-2-git-send-email-sebastian@breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®