From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752935Ab1LSX2W (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Dec 2011 18:28:22 -0500
Received: from merlin.infradead.org ([205.233.59.134]:46344 "EHLO
	merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752232Ab1LSX2T convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Dec 2011 18:28:19 -0500
Message-ID: <1324337287.24621.22.camel@twins>
Subject: Re: [PATCH 2/2] tracing, sched: Add delay info to sched_switch
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Andrew Vagin <avagin@openvz.org>,
        Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@elte.hu>
Date: Tue, 20 Dec 2011 00:28:07 +0100
In-Reply-To: <1324337005-31718-3-git-send-email-asharma@fb.com>
References: <1324337005-31718-1-git-send-email-asharma@fb.com>
	 <1324337005-31718-3-git-send-email-asharma@fb.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Evolution 3.2.1- 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2011-12-19 at 15:23 -0800, Arun Sharma wrote:
> +#ifdef CONFIG_SCHEDSTATS
> +               __entry->delay          = next->se.statistics.block_start ? next->se.statistics.block_start
> +                                         : next->se.statistics.sleep_start ? next->se.statistics.sleep_start : 0;
> +               __entry->delay = __entry->delay ? now - __entry->delay : 0;
> +#else
> +               __entry->delay = 0;
> +#endif 

I don't really like this, this should be one of those sched_*_stat
thingies, not sched_switch().