From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332Ab1LUF6Y (ORCPT ); Wed, 21 Dec 2011 00:58:24 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:36422 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752140Ab1LUF6U (ORCPT ); Wed, 21 Dec 2011 00:58:20 -0500 Message-ID: <1324447099.21340.6.camel@joe2Laptop> Subject: Re: [PATCH] vmalloc: remove #ifdef in function body From: Joe Perches To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML Date: Tue, 20 Dec 2011 21:58:19 -0800 In-Reply-To: <20111221054531.GB28505@barrios-laptop.redhat.com> References: <1324444679-9247-1-git-send-email-minchan@kernel.org> <1324445481.20505.7.camel@joe2Laptop> <20111221054531.GB28505@barrios-laptop.redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-12-21 at 14:45 +0900, Minchan Kim wrote: > On Tue, Dec 20, 2011 at 09:31:21PM -0800, Joe Perches wrote: > > On Wed, 2011-12-21 at 14:17 +0900, Minchan Kim wrote: > > > We don't like function body which include #ifdef. [] > > I don't like this change. > > I think it's perfectly good style to use: > I feel it's no problem as it is because it's very short function now > but it's not style we prefer. Who is this "we" you refer to? There's nothing suggesting your patch as a preferred style in Documentation/CodingStyle. cheers, Joe