From: Joerg Roedel <joerg.roedel@amd.com>
To: <iommu@lists.linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, Joerg Roedel <joerg.roedel@amd.com>
Subject: [PATCH 1/3] iommu/amd: Remove unnecessary cache flushes in amd_iommu_resume
Date: Thu, 22 Dec 2011 15:01:17 +0100 [thread overview]
Message-ID: <1324562479-29755-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1324562479-29755-1-git-send-email-joerg.roedel@amd.com>
The caches are already flushed in enable_iommus(), so this
flush is not necessary.
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
drivers/iommu/amd_iommu_init.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index c7a5d7e..38784733 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1396,13 +1396,6 @@ static void amd_iommu_resume(void)
/* re-load the hardware */
enable_iommus();
-
- /*
- * we have to flush after the IOMMUs are enabled because a
- * disabled IOMMU will never execute the commands we send
- */
- for_each_iommu(iommu)
- iommu_flush_all_caches(iommu);
}
static int amd_iommu_suspend(void)
--
1.7.5.4
next prev parent reply other threads:[~2011-12-22 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 14:01 [Patch 0/3] Pending AMD IOMMU patches Joerg Roedel
2011-12-22 14:01 ` Joerg Roedel [this message]
2011-12-22 14:01 ` [PATCH 2/3] iommu/amd: Init stats for iommu=pt Joerg Roedel
2011-12-22 14:01 ` [PATCH 3/3] iommu/amd: Set IOTLB invalidation timeout Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324562479-29755-2-git-send-email-joerg.roedel@amd.com \
--to=joerg.roedel@amd.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®