mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"flyboy@gmail.com" <flyboy@gmail.com>
Subject: Re: [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic mode setup by bios
Date: Fri, 23 Dec 2011 11:01:29 -0800	[thread overview]
Message-ID: <1324666889.4167.35.camel@sbsiddha-desk.sc.intel.com> (raw)
In-Reply-To: <CAE9FiQUeB-3uxJAMiHsz=uPWoFv5Hg1pVepz7aU6YtqOxMC-=Q@mail.gmail.com>

On Wed, 2011-12-21 at 23:24 -0800, Yinghai Lu wrote:
> On Wed, Dec 21, 2011 at 5:45 PM, Suresh Siddha
> <suresh.b.siddha@intel.com> wrote:
> 
> > @@ -1453,12 +1462,17 @@ static void disable_x2apic(void)
> >        if (msr & X2APIC_ENABLE) {
> >                u32 x2apic_id = read_apic_id();
> >
> > -               if (x2apic_id > 255)
> > -                       panic("Can not disable x2apic, id: %08x\n", x2apic_id);
> > +               if (x2apic_id >= 255)
> > +                       panic("Cannot disable x2apic, id: %08x\n", x2apic_id);
> 
> can not be applied cleanly.
> 
> update it a little bit.
> 
> need to use attached one to replace 4/5.
> 

Thanks Yinghai. updated patch look good.

Ingo, can you please queue this series to -tip?

thanks,
suresh


  reply	other threads:[~2011-12-23 18:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-22  1:45 [patch 0/5] x86: allow pre-enabled x2apic mode to be disabled Suresh Siddha
2011-12-22  1:45 ` [patch 1/5] x86, apic: add probe() for apic_flat Suresh Siddha
2011-12-23 20:10   ` [tip:x86/apic] x86, apic: Add " tip-bot for Yinghai Lu
2011-12-22  1:45 ` [patch 2/5] x86, acpi: skip acpi x2apic entries if the x2apic feature is not present Suresh Siddha
2011-12-23 20:11   ` [tip:x86/apic] x86, acpi: Skip " tip-bot for Yinghai Lu
2011-12-22  1:45 ` [patch 3/5] x86, x2apic: fallback to xapic when bios doesnt setup interrupt-remapping Suresh Siddha
2011-12-23 20:12   ` [tip:x86/apic] x86, x2apic: Fallback to xapic when BIOS doesn' t " tip-bot for Yinghai Lu
2011-12-22  1:45 ` [patch 4/5] x86, x2apic: allow "nox2apic" to disable x2apic mode setup by bios Suresh Siddha
2011-12-22  7:24   ` Yinghai Lu
2011-12-23 19:01     ` Suresh Siddha [this message]
2011-12-23 20:13     ` [tip:x86/apic] x86, x2apic: Allow "nox2apic" to disable x2apic mode setup by BIOS tip-bot for Yinghai Lu
2011-12-22  1:45 ` [patch 5/5] x86: skip cpus with apic-ids >= 255 in !x2apic_mode Suresh Siddha
2011-12-23 20:13   ` [tip:x86/apic] x86: Skip " tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324666889.4167.35.camel@sbsiddha-desk.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=flyboy@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®