From: Chinmay V S <cvs268@gmail.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Chinmay V S <cvs268@gmail.com>
Subject: [PATCH] Optimise apply_slack() for faster execution
Date: Mon, 26 Dec 2011 02:35:48 +0530 [thread overview]
Message-ID: <1324847148-20834-1-git-send-email-cvs268@gmail.com> (raw)
This patch simplifies the apply_slack() function in the kernel timer
subsystem. This is frequently called in mod_timer()/add_timer() and will
thus improve the performance of both the functions.
The existing logic used an intermediate-mask and a set of bitwise
operations using the mask to round-off the expires_limit variable. This
patch discards the intermediate-mask in favour of direct
shift-operations.
Signed-off-by: Chinmay V S <cvs268@gmail.com>
---
kernel/timer.c | 22 +++++++++-------------
1 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/kernel/timer.c b/kernel/timer.c
index 9c3c62b..3fc1f48 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -739,37 +739,33 @@ EXPORT_SYMBOL(mod_timer_pending);
* Algorithm:
* 1) calculate the maximum (absolute) time
* 2) calculate the highest bit where the expires and new max are different
- * 3) use this bit to make a mask
- * 4) use the bitmask to round down the maximum time, so that all last
- * bits are zeros
+ * 3) use this bit to round down maximum time, so that all last bits are 0
*/
static inline
unsigned long apply_slack(struct timer_list *timer, unsigned long expires)
{
- unsigned long expires_limit, mask;
+ unsigned long slack = 0;
int bit;
if (timer->slack >= 0) {
- expires_limit = expires + timer->slack;
+ slack = timer->slack;
} else {
long delta = expires - jiffies;
if (delta < 256)
return expires;
- expires_limit = expires + delta / 256;
+ slack = delta/256;
}
- mask = expires ^ expires_limit;
- if (mask == 0)
- return expires;
- bit = find_last_bit(&mask, BITS_PER_LONG);
+ if (slack == 0)
+ return expires;
- mask = (1 << bit) - 1;
+ bit = find_last_bit(&slack, BITS_PER_LONG);
- expires_limit = expires_limit & ~(mask);
+ expires = (expires >> bit) << bit;
- return expires_limit;
+ return expires;
}
/**
--
1.7.0.4
next reply other threads:[~2011-12-25 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 21:05 Chinmay V S [this message]
[not found] ` <CAK-9PRBFuVQG8cvmry5wtw7d2AM0v+D1eV+YTckox1mS7K6NGw@mail.gmail.com>
2011-12-27 11:36 ` Chinmay V S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324847148-20834-1-git-send-email-cvs268@gmail.com \
--to=cvs268@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome