From: Tao Guo <glorioustao@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: neilb@suse.de, axboe@fusionio.com,
Tao Guo <glorioustao@gmail.com>, Tao Guo <Tao.Guo@emc.com>
Subject: [PATCH] umem: fix up unplugging.
Date: Fri, 30 Dec 2011 09:17:31 -0500 [thread overview]
Message-ID: <1325254651-15379-1-git-send-email-glorioustao@gmail.com> (raw)
We need to implement unplugging to make umem start to work, or I/O
will never be triggered.
Signed-off-by: Tao Guo <Tao.Guo@emc.com>
---
drivers/block/umem.c | 33 ++++++++++++++++++++++++++++++++-
1 files changed, 32 insertions(+), 1 deletions(-)
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
index aa27120..c3bf98e 100644
--- a/drivers/block/umem.c
+++ b/drivers/block/umem.c
@@ -111,7 +111,8 @@ struct cardinfo {
int current_idx;
sector_t current_sector;
- struct request_queue *queue;
+ struct request_queue *queue;
+ struct blk_plug_cb plug_cb;
struct mm_page {
dma_addr_t page_dma;
@@ -513,6 +514,33 @@ static void process_page(unsigned long data)
}
}
+static void mm_unplug(struct blk_plug_cb *cb)
+{
+ struct cardinfo *card = container_of(cb, struct cardinfo, plug_cb);
+
+ spin_lock_irq(&card->lock);
+ activate(card);
+ spin_unlock_irq(&card->lock);
+}
+
+int mm_check_plugged(struct cardinfo *card)
+{
+ struct blk_plug *plug = current->plug;
+ struct cardinfo *c;
+
+ if (!plug)
+ return 0;
+
+ list_for_each_entry(c, &plug->cb_list, plug_cb.list) {
+ if (c == card)
+ return 1;
+ }
+
+ /* set up unplug callback */
+ list_add(&card->plug_cb.list, &plug->cb_list);
+ return 1;
+}
+
static void mm_make_request(struct request_queue *q, struct bio *bio)
{
struct cardinfo *card = q->queuedata;
@@ -523,6 +551,8 @@ static void mm_make_request(struct request_queue *q, struct bio *bio)
*card->biotail = bio;
bio->bi_next = NULL;
card->biotail = &bio->bi_next;
+ if (bio->bi_rw & REQ_SYNC || !mm_check_plugged(card))
+ activate(card);
spin_unlock_irq(&card->lock);
return;
@@ -884,6 +914,7 @@ static int __devinit mm_pci_probe(struct pci_dev *dev,
blk_queue_make_request(card->queue, mm_make_request);
card->queue->queue_lock = &card->lock;
card->queue->queuedata = card;
+ card->plug_cb.callback = mm_unplug;
tasklet_init(&card->tasklet, process_page, (unsigned long)card);
--
1.7.7
next reply other threads:[~2011-12-30 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 14:17 Tao Guo [this message]
2012-04-04 21:46 ` Andrew Morton
2012-04-04 22:20 ` Tao Guo
2012-04-04 23:18 ` Jens Axboe
2012-04-04 23:58 ` Tao Guo
2012-04-05 23:51 ` Jens Axboe
2012-04-06 4:09 ` Tao Guo
2012-04-06 4:19 ` Jens Axboe
2012-04-06 16:31 ` Tao Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325254651-15379-1-git-send-email-glorioustao@gmail.com \
--to=glorioustao@gmail.com \
--cc=Tao.Guo@emc.com \
--cc=axboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®