From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998Ab2ABMx7 (ORCPT ); Mon, 2 Jan 2012 07:53:59 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:33643 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752335Ab2ABMxZ (ORCPT ); Mon, 2 Jan 2012 07:53:25 -0500 From: Jamie Iles To: linux-kernel@vger.kernel.org Cc: devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, linus.walleij@stericsson.com, robherring2@gmail.com, Jamie Iles Subject: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block Date: Mon, 2 Jan 2012 12:53:16 +0000 Message-Id: <1325508798-25439-2-git-send-email-jamie@jamieiles.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1325508798-25439-1-git-send-email-jamie@jamieiles.com> References: <1325508798-25439-1-git-send-email-jamie@jamieiles.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Synopsys DesignWare block is used in some ARM devices (picoxcell) and can be configured to provide multiple banks of GPIO pins. v3: - depend on rather than select IRQ_DOMAIN - split IRQ support into a separate patch v2: - use Rob Herring's irqdomain in generic irq chip patches - use reg property to indicate bank index - support irqs on both edges based on LinusW's u300 driver Cc: Grant Likely Cc: Linus Walleij Acked-by: Rob Herring Signed-off-by: Jamie Iles --- .../devicetree/bindings/gpio/snps-dwapb-gpio.txt | 63 +++++++ drivers/gpio/Kconfig | 9 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-dwapb.c | 170 ++++++++++++++++++++ 4 files changed, 243 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt create mode 100644 drivers/gpio/gpio-dwapb.c diff --git a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt new file mode 100644 index 0000000..dccc113 --- /dev/null +++ b/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt @@ -0,0 +1,63 @@ +* Synopsys DesignWare APB GPIO controller + +Required properties: +- compatible : Should be "snps,dw-apb-gpio" +- reg : Address and length of the register set for the device + +The GPIO controller has a configurable number of banks, each of which are +represented as child nodes with the following properties: + +Required properties: +- compatible : "snps,dw-apb-gpio-bank" +- gpio-controller : Marks the device node as a gpio controller. +- #gpio-cells : Should be two. The first cell is the pin number and + the second cell is used to specify optional parameters (currently + unused). +- reg : The integer bank index of the bank, a single cell. +- nr-gpio : The number of pins in the bank, a single cell. + +Optional properties: +- interrupt-controller : The first bank may be configured to be an interrupt +controller. +- #interrupt-cells : Specifies the number of cells needed to encode an +interrupt. Shall be set to 2. The first cell defines the interrupt number, +the second encodes the triger flags encoded as: + + bits[3:0] trigger type and level flags. + 1 = low-to-high edge triggered + 2 = high-to-low edge triggered + 4 = active high level-sensitive + 8 = active low level-sensitive + +- interrupt-parent : The parent interrupt controller. +- interrupts : The interrupts to the parent controller raised when GPIOs +generate the interrupts. + +Example: + +gpio: gpio@20000 { + compatible = "snps,dw-apb-gpio"; + reg = <0x20000 0x1000>; + #address-cells = <1>; + #size-cells = <0>; + + banka: gpio-controller@0 { + compatible = "snps,dw-apb-gpio-bank"; + gpio-controller; + #gpio-cells = <2>; + nr-gpio = <8>; + reg = <0>; + interrupt-controller; + #interrupt-cells = <2>; + interrupt-parent = <&vic1>; + interrupts = <0 1 2 3 4 5 6 7>; + }; + + bankb: gpio-controller@1 { + compatible = "snps,dw-apb-gpio-bank"; + gpio-controller; + #gpio-cells = <2>; + nr-gpio = <8>; + reg = <1>; + }; +}; diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 8482a23..a82f61e 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -85,6 +85,15 @@ config GPIO_GENERIC_PLATFORM help Say yes here to support basic platform_device memory-mapped GPIO controllers. +config GPIO_DWAPB + bool "Synopsys DesignWare APB GPIO driver" + select GPIO_GENERIC + select GENERIC_IRQ_CHIP + depends on OF_GPIO + help + Say Y or M here to build support for the Synopsys DesignWare APB + GPIO block. This requires device tree support. + config GPIO_IT8761E tristate "IT8761E GPIO support" help diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index dbcb0bc..22665a0 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile @@ -15,6 +15,7 @@ obj-$(CONFIG_GPIO_BT8XX) += gpio-bt8xx.o obj-$(CONFIG_GPIO_CS5535) += gpio-cs5535.o obj-$(CONFIG_GPIO_DA9052) += gpio-da9052.o obj-$(CONFIG_ARCH_DAVINCI) += gpio-davinci.o +obj-$(CONFIG_GPIO_DWAPB) += gpio-dwapb.o obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c new file mode 100644 index 0000000..fb98274 --- /dev/null +++ b/drivers/gpio/gpio-dwapb.c @@ -0,0 +1,170 @@ +/* + * Copyright (c) 2011 Jamie Iles + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * All enquiries to support@picochip.com + */ +#include +#include +#include +#include +#include +#include +#include +#include + +struct dwapb_gpio; + +struct dwapb_gpio_bank { + struct bgpio_chip bgc; + unsigned int bank_idx; + bool is_registered; + struct dwapb_gpio *gpio; +}; + +struct dwapb_gpio { + struct device_node *of_node; + struct device *dev; + void __iomem *regs; + struct dwapb_gpio_bank *banks; + unsigned int nr_banks; +}; + +static unsigned int dwapb_gpio_nr_banks(struct device_node *of_node) +{ + unsigned int nr_banks = 0; + struct device_node *np; + + for_each_child_of_node(of_node, np) + ++nr_banks; + + return nr_banks; +} + +static int dwapb_gpio_add_bank(struct dwapb_gpio *gpio, + struct device_node *bank_np) +{ + struct dwapb_gpio_bank *bank; + u32 bank_idx, ngpio; + int err; + + if (of_property_read_u32(bank_np, "reg", &bank_idx)) { + dev_err(gpio->dev, "invalid bank index for %s\n", + bank_np->full_name); + return -EINVAL; + } + bank = &gpio->banks[bank_idx]; + bank->gpio = gpio; + + if (of_property_read_u32(bank_np, "nr-gpio", &ngpio)) { + dev_err(gpio->dev, "failed to get number of gpios for %s\n", + bank_np->full_name); + return -EINVAL; + } + + bank->bank_idx = bank_idx; + err = bgpio_init(&bank->bgc, gpio->dev, 4, + gpio->regs + 0x50 + (bank_idx * 0x4), + gpio->regs + 0x00 + (bank_idx * 0xc), + NULL, gpio->regs + 0x04 + (bank_idx * 0xc), NULL, + false); + if (err) { + dev_err(gpio->dev, "failed to init gpio chip for %s\n", + bank_np->full_name); + return err; + } + + bank->bgc.gc.ngpio = ngpio; + bank->bgc.gc.of_node = bank_np; + + err = gpiochip_add(&bank->bgc.gc); + if (err) + dev_err(gpio->dev, "failed to register gpiochip for %s\n", + bank_np->full_name); + else + bank->is_registered = true; + + return err; +} + +static void dwapb_gpio_unregister(struct dwapb_gpio *gpio) +{ + unsigned int m; + + for (m = 0; m < gpio->nr_banks; ++m) + if (gpio->banks[m].is_registered) + WARN_ON(gpiochip_remove(&gpio->banks[m].bgc.gc)); + of_node_put(gpio->of_node); +} + +static int __devinit dwapb_gpio_probe(struct platform_device *pdev) +{ + struct resource *res; + struct dwapb_gpio *gpio; + struct device_node *np; + int err; + + gpio = devm_kzalloc(&pdev->dev, sizeof(*gpio), GFP_KERNEL); + if (!gpio) + return -ENOMEM; + gpio->dev = &pdev->dev; + + gpio->nr_banks = dwapb_gpio_nr_banks(pdev->dev.of_node); + if (!gpio->nr_banks) + return -EINVAL; + gpio->banks = devm_kzalloc(&pdev->dev, gpio->nr_banks * + sizeof(*gpio->banks), GFP_KERNEL); + if (!gpio->banks) + return -ENOMEM; + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) { + dev_err(&pdev->dev, "failed to get iomem\n"); + return -ENXIO; + } + gpio->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); + if (!gpio->regs) + return -ENOMEM; + + gpio->of_node = of_node_get(pdev->dev.of_node); + for_each_child_of_node(pdev->dev.of_node, np) { + err = dwapb_gpio_add_bank(gpio, np); + if (err) + goto out_unregister; + } + platform_set_drvdata(pdev, gpio); + + return 0; + +out_unregister: + dwapb_gpio_unregister(gpio); + + return err; +} + +static const struct of_device_id dwapb_of_match_table[] = { + { .compatible = "snps,dw-apb-gpio" }, + { /* Sentinel */ } +}; + +static struct platform_driver dwapb_gpio_driver = { + .driver = { + .name = "gpio-dwapb", + .owner = THIS_MODULE, + .of_match_table = dwapb_of_match_table, + }, + .probe = dwapb_gpio_probe, +}; + +static int __init dwapb_gpio_init(void) +{ + return platform_driver_register(&dwapb_gpio_driver); +} +postcore_initcall(dwapb_gpio_init); + +MODULE_LICENSE("GPL"); +MODULE_AUTHOR("Jamie Iles"); +MODULE_DESCRIPTION("Synopsys DesignWare APB GPIO driver"); -- 1.7.5.4