From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855Ab2ACOWK (ORCPT ); Tue, 3 Jan 2012 09:22:10 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:47511 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753694Ab2ACOUS (ORCPT ); Tue, 3 Jan 2012 09:20:18 -0500 From: Gilad Ben-Yossef To: linux-kernel@vger.kernel.org Cc: Gilad Ben-Yossef , Michal Nazarewicz , David Airlie Subject: [RFC PATCH 6/9] agp: avoid using on_each_cpu hard coded ret value Date: Tue, 3 Jan 2012 16:19:10 +0200 Message-Id: <1325600353-10895-7-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1325600353-10895-1-git-send-email-gilad@benyossef.com> References: <1325600353-10895-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. CC: Michal Nazarewicz CC: David Airlie --- drivers/char/agp/generic.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c index b072648..b6a6f6f 100644 --- a/drivers/char/agp/generic.c +++ b/drivers/char/agp/generic.c @@ -1329,8 +1329,7 @@ static void ipi_handler(void *null) void global_cache_flush(void) { - if (on_each_cpu(ipi_handler, NULL, 1) != 0) - panic(PFX "timed out waiting for the other CPUs!\n"); + on_each_cpu(ipi_handler, NULL, 1); } EXPORT_SYMBOL(global_cache_flush); -- 1.7.0.4