mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gilad Ben-Yossef <gilad@benyossef.com>
To: linux-kernel@vger.kernel.org
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org
Subject: [RFC PATCH 7/9] drm: avoid using on_each_cpu hard coded ret value
Date: Tue,  3 Jan 2012 16:19:11 +0200	[thread overview]
Message-ID: <1325600353-10895-8-git-send-email-gilad@benyossef.com> (raw)
In-Reply-To: <1325600353-10895-1-git-send-email-gilad@benyossef.com>

on_each_cpu always returns a hard coded return code of zero.

Removing all tests based on this return value saves run time
cycles for compares and code bloat for branches.

CC: Michal Nazarewicz <mina86@mina86.com>
CC: David Airlie <airlied@linux.ie>
CC: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/drm_cache.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c
index 5928653..668653c 100644
--- a/drivers/gpu/drm/drm_cache.c
+++ b/drivers/gpu/drm/drm_cache.c
@@ -75,8 +75,7 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
 		return;
 	}
 
-	if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0)
-		printk(KERN_ERR "Timed out waiting for cache flush.\n");
+	on_each_cpu(drm_clflush_ipi_handler, NULL, 1);
 
 #elif defined(__powerpc__)
 	unsigned long i;
-- 
1.7.0.4


  parent reply	other threads:[~2012-01-03 14:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 14:19 [RFC PATCH 0/9] Remove useless on_each_cpu return value Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 1/9] arm: avoid using on_each_cpu hard coded ret value Gilad Ben-Yossef
2012-01-09  8:28   ` Uwe Kleine-König
2012-01-03 14:19 ` [RFC PATCH 2/9] ia64: " Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 3/9] x86: " Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 4/9] alpha: " Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 5/9] ppc: " Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 6/9] agp: " Gilad Ben-Yossef
2012-01-03 14:19 ` Gilad Ben-Yossef [this message]
2012-01-03 14:19 ` [RFC PATCH 8/9] smp: refactor on_each_cpu to void returning func Gilad Ben-Yossef
2012-01-03 14:19 ` [RFC PATCH 9/9] x86: refactor wbinvd_on_all_cpus to void function Gilad Ben-Yossef
2012-01-03 14:25 ` [RFC PATCH 0/9] Remove useless on_each_cpu return value Michal Nazarewicz
2012-01-03 16:08   ` Gilad Ben-Yossef
2012-01-06 13:03 ` Peter Zijlstra
2012-01-08 16:10   ` Gilad Ben-Yossef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325600353-10895-8-git-send-email-gilad@benyossef.com \
    --to=gilad@benyossef.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mina86@mina86.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®