From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758106Ab2AEH7t (ORCPT ); Thu, 5 Jan 2012 02:59:49 -0500 Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:29787 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758094Ab2AEH7o (ORCPT ); Thu, 5 Jan 2012 02:59:44 -0500 X-SpamScore: 0 X-BigFish: VS0(zzzz1202hzz8275dhz2dh87h2a8h668h839h) X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-FB-DOMAIN-IP-MATCH: fail From: Richard Zhao To: , CC: , , , , , , Richard Zhao Subject: [PATCH v3 2/2] dma/imx-sdma: use writel to write register when enable a channel Date: Thu, 5 Jan 2012 15:59:22 +0800 Message-ID: <1325750362-22598-3-git-send-email-richard.zhao@linaro.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1325750362-22598-1-git-send-email-richard.zhao@linaro.org> References: <1325750362-22598-1-git-send-email-richard.zhao@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-OriginatorOrg: sigmatel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma_alloc_coherent memory may be bufferable when set CONFIG_ARM_DMA_MEM_BUFFERABLE. We need to add nececcary memory barrier. writel implicitly call wmb in such case. Signed-off-by: Richard Zhao --- drivers/dma/imx-sdma.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index c2bc4f1..e987468 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -396,7 +396,7 @@ static int sdma_config_ownership(struct sdma_channel *sdmac, static void sdma_enable_channel(struct sdma_engine *sdma, int channel) { - __raw_writel(1 << channel, sdma->regs + SDMA_H_START); + writel(1 << channel, sdma->regs + SDMA_H_START); } /* -- 1.7.5.4