From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964808Ab2AEQiO (ORCPT ); Thu, 5 Jan 2012 11:38:14 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:34846 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932488Ab2AEQiM (ORCPT ); Thu, 5 Jan 2012 11:38:12 -0500 Message-ID: <1325781489.22154.19.camel@joe2Laptop> Subject: Re: [PATCH v2 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions From: Joe Perches To: Kalle Valo Cc: linville@tuxdriver.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, ath6kl-devel@qualcomm.com, davem@davemloft.net Date: Thu, 05 Jan 2012 08:38:09 -0800 In-Reply-To: <20120105132834.22281.78822.stgit@x201> References: <20120105132523.22281.95999.stgit@x201> <20120105132834.22281.78822.stgit@x201> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-01-05 at 15:28 +0200, Kalle Valo wrote: Hey Kalle. > diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c [] > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...) [] > + ath6kl_printk(KERN_DEBUG, "%pV", &vaf); [ > diff --git a/drivers/net/wireless/ath/ath6kl/debug.h b/drivers/net/wireless/ath/ath6kl/debug.h [] > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...); You need to add __printf(2, 3) to the prototype. If it's not there, the printf formats and arguments aren't verified. %pV could do the wrong/bad things.