From: Joe Perches <joe@perches.com>
To: Alessandro Rubini <rubini@gnudd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] x86: initial support for sta2x11
Date: Sat, 07 Jan 2012 02:05:57 -0800 [thread overview]
Message-ID: <1325930757.14763.4.camel@joe2Laptop> (raw)
In-Reply-To: <20120107082212.GA18254@mail.gnudd.com>
On Sat, 2012-01-07 at 09:22 +0100, Alessandro Rubini wrote:
> > or __func__
> I don't understand. No size? Or you typoed and meant pr_fmt defined above?
I meant that outputting __func__ (in this case
sta2x11_new_instance) doesn't gain much useful
information and generally isn't necessary.
> >> + uint32_t v[2]; /* used as a string... */
> > less than pretty.
> Sure. But it's informative. Do you prefer a union?
Not really.
prev parent reply other threads:[~2012-01-07 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 12:32 [PATCH 1/6] pci_ids: add device ids for STA2X11 device (aka ConneXT) Alessandro Rubini
2012-01-06 12:32 ` [PATCH 2/6] x86: introduce CONFIG_X86_DEV_DMA_OPS Alessandro Rubini
2012-01-06 12:33 ` [PATCH 3/6] x86: introduce CONFIG_X86_DMA_REMAP Alessandro Rubini
2012-01-06 12:33 ` [PATCH 4/6] x86: initial support for sta2x11 Alessandro Rubini
2012-01-06 12:33 ` [PATCH 5/6] usb: add support for STA2X11 host driver Alessandro Rubini
2012-01-06 16:35 ` Alan Stern
2012-01-06 17:57 ` Alessandro Rubini
2012-01-06 12:33 ` [PATCH 6/6] ahci: support the STA2X11 I/O Hub Alessandro Rubini
2012-01-11 22:57 ` Alan Cox
2012-01-11 23:26 ` Alessandro Rubini
2012-01-06 20:11 ` [PATCH 1/6] pci_ids: add device ids for STA2X11 device (aka ConneXT) Jesse Barnes
2012-01-06 20:18 ` Alessandro Rubini
[not found] ` <1446410617.668.1325893939253.JavaMail.mail@webmail05>
2012-01-07 0:05 ` [PATCH 4/6] x86: initial support for sta2x11 Joe Perches
2012-01-07 8:22 ` Alessandro Rubini
2012-01-07 10:05 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325930757.14763.4.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome