From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801Ab2AHNeS (ORCPT ); Sun, 8 Jan 2012 08:34:18 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:57563 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714Ab2AHNdg (ORCPT ); Sun, 8 Jan 2012 08:33:36 -0500 From: Gilad Ben-Yossef To: linux-kernel@vger.kernel.org Cc: Gilad Ben-Yossef , David Airlie , dri-devel@lists.freedesktop.org Subject: [RFC PATCH v2 7/9] drm: avoid using on_each_cpu hard coded ret value Date: Sun, 8 Jan 2012 15:32:27 +0200 Message-Id: <1326029549-2794-8-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1326029549-2794-1-git-send-email-gilad@benyossef.com> References: <1326029549-2794-1-git-send-email-gilad@benyossef.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on_each_cpu always returns a hard coded return code of zero. Removing all tests based on this return value saves run time cycles for compares and code bloat for branches. Signed-off-by: Gilad Ben-Yossef Acked-by: Peter Zijlstra Reviewed-by: Michal Nazarewicz CC: David Airlie CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/drm_cache.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c index 5928653..668653c 100644 --- a/drivers/gpu/drm/drm_cache.c +++ b/drivers/gpu/drm/drm_cache.c @@ -75,8 +75,7 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages) return; } - if (on_each_cpu(drm_clflush_ipi_handler, NULL, 1) != 0) - printk(KERN_ERR "Timed out waiting for cache flush.\n"); + on_each_cpu(drm_clflush_ipi_handler, NULL, 1); #elif defined(__powerpc__) unsigned long i; -- 1.7.0.4