From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <rw@linutronix.de>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] [RFC] ubi: Make vid_hdr non-static
Date: Mon, 09 Jan 2012 17:12:28 +0200 [thread overview]
Message-ID: <1326121948.6755.102.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1324569962.1165.6.camel@sauron.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Thu, 2011-12-22 at 18:06 +0200, Artem Bityutskiy wrote:
> On Thu, 2011-12-22 at 16:12 +0100, Richard Weinberger wrote:
> > There is no reason to have vid_hdr static.
> >
> > Signed-off-by: Richard Weinberger <rw@linutronix.de>
> > ---
> > drivers/mtd/ubi/vtbl.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
> > index 9ad18da..890754c 100644
> > --- a/drivers/mtd/ubi/vtbl.c
> > +++ b/drivers/mtd/ubi/vtbl.c
> > @@ -306,7 +306,7 @@ static int create_vtbl(struct ubi_device *ubi, struct ubi_scan_info *si,
> > int copy, void *vtbl)
> > {
> > int err, tries = 0;
> > - static struct ubi_vid_hdr *vid_hdr;
> > + struct ubi_vid_hdr *vid_hdr;
> > struct ubi_scan_leb *new_seb;
>
> Hmm, this shouldn't be [RFC] - this a bugfix, I'll merge it, thanks!
Pushed to ubifs-2.6 git tree with "Cc: stable@kernel.org", thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-01-09 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 15:12 Richard Weinberger
2011-12-22 16:06 ` Artem Bityutskiy
2011-12-22 16:05 ` Richard Weinberger
2012-01-09 15:12 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326121948.6755.102.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rw@linutronix.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome