From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932087Ab2AIPQo (ORCPT ); Mon, 9 Jan 2012 10:16:44 -0500 Received: from smtp.eu.citrix.com ([62.200.22.115]:62683 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755570Ab2AIPQn (ORCPT ); Mon, 9 Jan 2012 10:16:43 -0500 X-IronPort-AV: E=Sophos;i="4.71,480,1320624000"; d="scan'208";a="9899758" Subject: Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id. From: Ian Campbell To: Konrad Rzeszutek Wilk CC: "linux-pci@vger.kernel.org" , "jbarnes@virtuousgeek.org" , "xen-devel@lists.xensource.com" , "linux-kernel@vger.kernel.org" , Jan Beulich Date: Mon, 9 Jan 2012 15:16:12 +0000 In-Reply-To: <20120109151124.GE25563@phenom.dumpdata.com> References: <1325724403-29642-1-git-send-email-konrad.wilk@oracle.com> <1325724403-29642-5-git-send-email-konrad.wilk@oracle.com> <4F06C101020000780006AC32@nat28.tlf.novell.com> <20120106150338.GB5855@phenom.dumpdata.com> <1325865086.25206.512.camel@zakaz.uk.xensource.com> <20120106160011.GD6125@phenom.dumpdata.com> <20120106221927.GA10248@phenom.dumpdata.com> <1326102657.17210.11.camel@zakaz.uk.xensource.com> <20120109151124.GE25563@phenom.dumpdata.com> Organization: Citrix Systems, Inc. Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.0.3- Content-Transfer-Encoding: 7bit Message-ID: <1326122172.17210.109.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2012-01-09 at 15:11 +0000, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 09, 2012 at 09:50:57AM +0000, Ian Campbell wrote: > > On Fri, 2012-01-06 at 22:19 +0000, Konrad Rzeszutek Wilk wrote: > > > > > I suppose you might want "Overriding ownership to dom%d". > > > > > > > > OK. To the point and potentially can fit in 80 lines :-). > > > > > > how about this? > > > > > > > From a3d4a80cdfd4274016522572148a89260b3f3de6 Mon Sep 17 00:00:00 2001 > > > From: Konrad Rzeszutek Wilk > > > Date: Wed, 4 Jan 2012 14:16:45 -0500 > > > Subject: [PATCH] xen/pciback: Expand the warning message to include domain > > > id. > > > > > > When a PCI device is transferred to another domain and it is still > > > in usage (from the internal perspective), mention which other > > > domain is using it to aid in debugging. > > > > > > [v2: Truncate the verbose message per Jan Beulich suggestion] > > > Signed-off-by: Konrad Rzeszutek Wilk > > > --- > > > drivers/xen/xen-pciback/xenbus.c | 4 ++-- > > > 1 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/xen/xen-pciback/xenbus.c b/drivers/xen/xen-pciback/xenbus.c > > > index 474d52e..2405a24 100644 > > > --- a/drivers/xen/xen-pciback/xenbus.c > > > +++ b/drivers/xen/xen-pciback/xenbus.c > > > @@ -243,8 +243,8 @@ static int xen_pcibk_export_device(struct xen_pcibk_device *pdev, > > > dev_dbg(&dev->dev, "registering for %d\n", pdev->xdev->otherend_id); > > > if (xen_register_device_domain_owner(dev, > > > pdev->xdev->otherend_id) != 0) { > > > - dev_err(&dev->dev, "device has been assigned to another " \ > > > - "domain! Over-writting the ownership, but beware.\n"); > > > + dev_err(&dev->dev, "Overriding ownership to dom%d.\n", > > > + xen_find_device_domain_owner(dev)); > > > > That sounds like you are going to be assigning the ownership to that > > dom, but xen_find_device_domain_owner so aren't you actually steeling > > ownership from that domain? > > Duh! I will do s/to/from/ Maybe s/Overriding/Stealing/ too? "Overriding ownership from xxx" sounds a bit odd to me. Ian.