From: Peter Huewe <peterhuewe@gmx.de>
To: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Arnaud Patard <arnaud.patard@rtp-net.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Dan Carpenter <dan.carpenter@oracle.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH 1/4] staging/xgifb: Remove unsupported mode LCD_320x480
Date: Sun, 15 Jan 2012 19:22:10 +0100 [thread overview]
Message-ID: <1326651733-9242-2-git-send-email-peterhuewe@gmx.de> (raw)
In-Reply-To: <1326651733-9242-1-git-send-email-peterhuewe@gmx.de>
This patch removes the probed mode LCD_320x480 which isn't supported
anyway since this mode falls through to the default (=invalid) mode in the
XGIfb_validate_mode function (see line 529 ff. for details).
By removing this assignment, we can use the LCD_TYPEs from the sis
driver without modifications.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
drivers/staging/xgifb/XGI_main_26.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 2502c49..c27dbf8 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -2118,10 +2118,13 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
reg &= 0x0f;
hw_info->ulCRT2LCDType = XGI310paneltype[reg];
- } else {
+ }
+ #if 0
+ else {
/* TW: FSTN/DSTN */
hw_info->ulCRT2LCDType = LCD_320x480;
- }
+ } /* maybe we re-add this later on */
+ #endif
}
if ((hw_info->ujVBChipID == VB_CHIP_302B) ||
--
1.7.3.4
next prev parent reply other threads:[~2012-01-15 18:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 18:22 staging/xgifb: Use sis headers and remove duplicated structs and defines Peter Huewe
2012-01-15 18:22 ` Peter Huewe [this message]
2012-01-15 18:54 ` [PATCH 1/4] staging/xgifb: Remove unsupported mode LCD_320x480 Dan Carpenter
2012-01-15 19:34 ` [PATCH 1/4 v2] " Peter Huewe
2012-01-15 18:22 ` [PATCH 2/4] staging/xgifb: Include sis headers Peter Huewe
2012-01-15 18:22 ` [PATCH 3/4] staging/xgifb: Use structs and defines from the " Peter Huewe
2012-01-15 18:22 ` [PATCH 4/4] staging/xgifb: Remove remaining duplicate structs and defines Peter Huewe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326651733-9242-2-git-send-email-peterhuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®