mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Jesper Juhl <jj@chaosbits.net>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
	Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [PATCH][Trivial] Fix up version number reference in include/trace/events/power.h
Date: Sun, 15 Jan 2012 16:09:44 -0500	[thread overview]
Message-ID: <1326661784.7642.140.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1201152146570.13389@swampdragon.chaosbits.net>

On Sun, 2012-01-15 at 21:48 +0100, Jesper Juhl wrote:
> What was originally going to be 2.6.41 became 3.1 .
> 
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
>  include/trace/events/power.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> index 1bcc2a8..b262699 100644
> --- a/include/trace/events/power.h
> +++ b/include/trace/events/power.h
> @@ -65,7 +65,7 @@ TRACE_EVENT(machine_suspend,
>  	TP_printk("state=%lu", (unsigned long)__entry->state)
>  );
>  
> -/* This code will be removed after deprecation time exceeded (2.6.41) */
> +/* This code will be removed after deprecation time exceeded (3.1) */

Shouldn't the real fix be to remove this code? What's the use of
changing the version number that this code will be removed from, when
the change won't get in until after the version that this code should
have been removed?

This is like updating 2014 calendars to say the world will end in 2012.

-- Steve

>  #ifdef CONFIG_EVENT_POWER_TRACING_DEPRECATED
>  
>  /*
> -- 
> 1.7.8.3
> 
> 



  reply	other threads:[~2012-01-15 21:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 20:48 Jesper Juhl
2012-01-15 21:09 ` Steven Rostedt [this message]
2012-01-15 21:12   ` Jesper Juhl
2012-02-03 21:42     ` Jiri Kosina
2012-02-03 21:51       ` Arjan van de Ven
2012-02-04 15:15         ` Steven Rostedt
2012-02-04 22:31           ` Jesper Juhl
2012-02-06 19:25             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326661784.7642.140.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=arjan@linux.intel.com \
    --cc=fweisbec@gmail.com \
    --cc=jj@chaosbits.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®