mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH] dmatest: fix merge error resulting in incorrect count handling
Date: Wed, 18 Jan 2012 19:21:55 -0500	[thread overview]
Message-ID: <1326932515-7293-1-git-send-email-paul.gortmaker@windriver.com> (raw)

We currently see this warning:

  drivers/dma/dmatest.c: In function ‘dmatest_add_channel’:
  drivers/dma/dmatest.c:602:28: warning: the omitted middle operand
   in ?: will always be ‘true’, suggest explicit middle operand [-Wparentheses]

It happens because commit f1aef8b6e6abf32a3a269542f95a19e2cb319f6c

  "dmaengine: dmatest: correct thread_count while using multiple thread per channel"

fixed the only two instances of this issue in the code, but then the
commit 58691d64c44ae41ddf098ecb31e9a994026e3cff "dmatest: add pq support"
was based on the old (unfixed) code, and so it reintroduced an instance
of this error.  Using git describe, the baseline delta is apparent:

	dmatest: correct thread_count	v2.6.30-8-gf1aef8b
	dmatest: add pq support		v2.6.29-rc8-80-g58691d6

Inspection of f1aef8b and/or the surrounding code leads one to the
obvious fix.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
CC: Nicolas Ferre <nicolas.ferre@atmel.com>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Vinod Koul <vinod.koul@intel.com>

---

[After creating this patch, I noticed it came up before in the
 lkml archives, but a fix never got applied.  At least now the
 real root cause is documented in this commit log.]

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 2b8661b..24225f0 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -599,7 +599,7 @@ static int dmatest_add_channel(struct dma_chan *chan)
 	}
 	if (dma_has_cap(DMA_PQ, dma_dev->cap_mask)) {
 		cnt = dmatest_add_threads(dtc, DMA_PQ);
-		thread_count += cnt > 0 ?: 0;
+		thread_count += cnt > 0 ? cnt : 0;
 	}
 
 	pr_info("dmatest: Started %u threads using %s\n",
-- 
1.7.7.2


             reply	other threads:[~2012-01-19  0:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  0:21 Paul Gortmaker [this message]
2012-01-19  8:21 ` Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326932515-7293-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome