From: Joe Perches <joe@perches.com>
To: Ulrich Windl <Ulrich.Windl@rz.uni-regensburg.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Change request: "scsi: killing requests for dead queue"
Date: Wed, 18 Jan 2012 23:58:17 -0800 [thread overview]
Message-ID: <1326959897.6404.17.camel@joe2Laptop> (raw)
In-Reply-To: <4F17D4C2020000A100008B19@gwsmtp1.uni-regensburg.de>
On Thu, 2012-01-19 at 08:30 +0100, Ulrich Windl wrote:
> Hi!
>
> I have a change request: I saw three message that I couldn't bring into context with any other event (SLES11 SP1 (2.6.32.49-0.3-default)):
>
> Jan 18 15:33:04 h03 kernel: [2866825.805434] scsi: killing requests for dead queue
> Jan 18 15:33:04 h03 kernel: [2866825.812129] scsi: killing requests for dead queue
> Jan 18 15:33:04 h03 kernel: [2866825.815553] scsi: killing requests for dead queue
>
> Unfortunately the kernel message doesn't give some kind of queue identifier, so that's hard to correlate with any other events.
>
> Can this message be improved to include some variable output?
It was improved by:
commit 745718132c3c7cac98a622b610e239dcd5217f71
Author: Hannes Reinecke <hare@suse.de>
Date: Wed Nov 9 08:39:24 2011 +0100
[SCSI] Silencing 'killing requests for dead queue'
When we tear down a device we try to flush all outstanding
commands in scsi_free_queue(). However the check in
scsi_request_fn() is imperfect as it only signals that
we _might start_ aborting commands, not that we've actually
aborted some.
So move the printk inside the scsi_kill_request function,
this will also give us a hint about which commands are aborted.
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
prev parent reply other threads:[~2012-01-19 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 7:30 Ulrich Windl
2012-01-19 7:58 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326959897.6404.17.camel@joe2Laptop \
--to=joe@perches.com \
--cc=Ulrich.Windl@rz.uni-regensburg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®