From: Eric Dumazet <eric.dumazet@gmail.com>
To: Viral Mehta <viral.vkm@gmail.com>
Cc: "Pradeep A. Dalvi" <netdev@pradeepdalvi.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netdev/ethernet: dev_alloc_skb to netdev_alloc_skb
Date: Mon, 23 Jan 2012 10:43:56 +0100 [thread overview]
Message-ID: <1327311836.2525.6.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <CANX6Da=Y5zJ4xi8=gLZZ8tUnnqxNCpvC0yBGruObWzYHrucLLg@mail.gmail.com>
Le lundi 23 janvier 2012 à 14:10 +0530, Viral Mehta a écrit :
> On Sun, Jan 22, 2012 at 2:27 AM, Pradeep A. Dalvi
> <netdev@pradeepdalvi.com> wrote:
> > Replaced deprecating dev_alloc_skb with netdev_alloc_skb in drivers/net/ethernet
> >
> > Signed-off-by: Pradeep A. Dalvi <netdev@pradeepdalvi.com>
>
> and these too ??
>
> vmehta@viralmehta:~/linux-3.2/drivers/infiniband/hw$ grep dev_alloc_skb -r .
> ./ipath/ipath_driver.c: skb = __dev_alloc_skb(len, gfp_mask);
> ./nes/nes_cm.c: skb = dev_alloc_skb(MAX_CM_BUFFER);
> ./nes/nes_cm.c: skb = dev_alloc_skb(MAX_CM_BUFFER);
Those should probably use a mere alloc_skb(), since they dont need the
NET_SKB_PAD
> ./nes/nes_cm.c: skb = dev_alloc_skb(MAX_CM_BUFFER);
> ./nes/nes_cm.c: skb = dev_alloc_skb(MAX_CM_BUFFER);
> ./nes/nes_cm.c: skb = dev_alloc_skb(MAX_CM_BUFFER);
> ./nes/nes_hw.c: skb = dev_alloc_skb(nesvnic->max_frame_size);
> ./nes/nes_hw.c: skb = dev_alloc_skb(nesvnic->max_frame_size);
> ./nes/nes_mgt.c: skb = dev_alloc_skb(mgtvnic->nesvnic->max_frame_size);
> ./nes/nes_mgt.c: skb = dev_alloc_skb(nesvnic->max_frame_size);
> ./amso1100/c2.c: skb = dev_alloc_skb(c2_port->rx_buf_size);
> vmehta@viralmehta:~/linux-3.2/drivers/infiniband/hw$
> --
next prev parent reply other threads:[~2012-01-23 9:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 20:57 Pradeep A. Dalvi
2012-01-23 8:40 ` Viral Mehta
2012-01-23 9:43 ` Eric Dumazet [this message]
2012-01-23 10:29 ` Pradeep A. Dalvi
2012-01-23 9:45 ` Eric Dumazet
2012-01-23 10:37 ` Pradeep A. Dalvi
2012-01-23 13:15 ` Pradeep A. Dalvi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327311836.2525.6.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@pradeepdalvi.com \
--cc=netdev@vger.kernel.org \
--cc=viral.vkm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®