From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stefan Gula <steweg@ynet.sk>
Cc: Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v1, kernel version 3.2.1] Source mode for macvlan interaface
Date: Mon, 23 Jan 2012 16:25:14 +0100 [thread overview]
Message-ID: <1327332314.2525.25.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> (raw)
In-Reply-To: <22013455.801327321838477.JavaMail.root@5-MeO-DMT.ynet.sk>
Le lundi 23 janvier 2012 à 13:30 +0100, Stefan Gula a écrit :
> +static void macvlan_forward_sources_one(struct sk_buff *skb,
> + struct macvlan_dev *vlan)
> +{
> + struct sk_buff *nskb;
> + struct net_device *dev;
> + int len;
> + int ret;
> +
> + dev = vlan->dev;
> + if (unlikely(!(dev->flags & IFF_UP)))
> + return;
> +
> + nskb = skb_clone(skb, GFP_ATOMIC);
> + if (!nskb)
> + return;
> +
> + len = nskb->len + ETH_HLEN;
> + nskb = skb_share_check(nskb, GFP_ATOMIC);
> + if (!nskb)
> + return;
I am trying to understand how/why skb_share_check() is needed/useful
after skb_clone() ...
next prev parent reply other threads:[~2012-01-23 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 12:30 Stefan Gula
2012-01-23 14:11 ` Eric Dumazet
2012-01-23 14:44 ` Štefan Gula
2012-01-23 17:08 ` Eric Dumazet
2012-01-23 15:25 ` Eric Dumazet [this message]
2012-01-23 18:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327332314.2525.25.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC \
--to=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steweg@ynet.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®