From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753357Ab2AWRIv (ORCPT ); Mon, 23 Jan 2012 12:08:51 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:63000 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202Ab2AWRIt (ORCPT ); Mon, 23 Jan 2012 12:08:49 -0500 Message-ID: <1327338525.2525.37.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Subject: Re: [patch v1, kernel version 3.2.1] Source mode for macvlan interaface From: Eric Dumazet To: =?UTF-8?Q?=C5=A0tefan?= Gula Cc: Patrick McHardy , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Jan 2012 18:08:45 +0100 In-Reply-To: References: <22013455.801327321838477.JavaMail.root@5-MeO-DMT.ynet.sk> <1327327879.2525.21.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le lundi 23 janvier 2012 à 15:44 +0100, Štefan Gula a écrit : > 2012/1/23 Eric Dumazet : > >> +static void macvlan_hash_del_sources(struct macvlan_source_list *list, > >> + bool sync) > >> +{ > >> + hlist_del_rcu(&list->hlist); > >> + kfree_rcu(list, rcu); > >> + if (sync) > >> + synchronize_rcu(); > >> +} > >> + > > > > Please explain why are you using synchronize_rcu() here, as there must > > be a good reason, but I missed it. > I though so, but I was not sure whether that should be removed or not > so I rather leave it there as I followed the original code structure > of macvlan driver. So should I remove it? If you use kfree_rcu(), its a call_rcu() : A grace period will be respected before the object freeing, so you dont need the synchronize_rcu() at all.