From: Frederic Weisbecker <fweisbec@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Arjan van de Ven <arjan@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
John Stultz <john.stultz@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 1/3] nohz: Remove update_ts_time_stat from tick_nohz_start_idle
Date: Tue, 24 Jan 2012 18:59:42 +0100 [thread overview]
Message-ID: <1327427984-23282-1-git-send-email-fweisbec@gmail.com> (raw)
From: Michal Hocko <mhocko@suse.cz>
There is no reason to call update_ts_time_stat from tick_nohz_start_idle
anymore (after e0e37c20 sched: Eliminate the ts->idle_lastupdate field)
when we updated idle_lastupdate unconditionally.
We haven't set idle_active yet and do not provide last_update_time so
the whole call end up being just 2 wasted branches.
Signed-off-by: Michal Hocko <mhocko@suse.cz>
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
CC: Arjan van de Ven <arjan@linux.intel.com>
CC: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
---
kernel/time/tick-sched.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
index 7656642..85a67e8 100644
--- a/kernel/time/tick-sched.c
+++ b/kernel/time/tick-sched.c
@@ -186,8 +186,6 @@ static ktime_t tick_nohz_start_idle(int cpu, struct tick_sched *ts)
now = ktime_get();
- update_ts_time_stats(cpu, ts, now, NULL);
-
ts->idle_entrytime = now;
ts->idle_active = 1;
sched_clock_idle_sleep_event();
--
1.7.5.4
next reply other threads:[~2012-01-24 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 17:59 Frederic Weisbecker [this message]
2012-01-24 17:59 ` [PATCH 2/3] nohz: Remove ts->inidle checks before restarting the tick Frederic Weisbecker
2012-02-15 19:38 ` [tip:timers/core] nohz: Remove ts-> Einidle " tip-bot for Frederic Weisbecker
2012-01-24 17:59 ` [PATCH 3/3] timer: Fix bad idle check on irq entry Frederic Weisbecker
2012-02-15 19:39 ` [tip:timers/core] " tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327427984-23282-1-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=arjan@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome