From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297Ab2AYI0R (ORCPT ); Wed, 25 Jan 2012 03:26:17 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:44630 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752768Ab2AYI0O (ORCPT ); Wed, 25 Jan 2012 03:26:14 -0500 Message-ID: <1327479959.21686.8.camel@joe2Laptop> Subject: Re: [PATCH v4] serial/efm32: add new driver From: Joe Perches To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Greg KH , linux-kernel@vger.kernel.org, Alan Cox , kernel@pengutronix.de, devicetree-discuss@lists.ozlabs.org, Greg Kroah-Hartman , linux-serial@vger.kernel.org Date: Wed, 25 Jan 2012 00:25:59 -0800 In-Reply-To: <1327478704-4233-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <20120124220522.GA10590@kroah.com> <1327478704-4233-1-git-send-email-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.2- Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2012-01-25 at 09:05 +0100, Uwe Kleine-König wrote: > Signed-off-by: Uwe Kleine-König trivial comments below: > diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c [] > @@ -0,0 +1,830 @@ > +#if defined(CONFIG_SERIAL_EFM32_UART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ) > +#define SUPPORT_SYSRQ > +#endif #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +static void efm32_uart_rx_chars(struct efm32_uart_port *efm_port, > + struct tty_struct *tty) > +{ [] > + if ((rxdata & UARTn_RXDATAX_FERR) && > + !(rxdata & UARTn_RXDATAX_RXDATA__MASK)) { Perhaps better as: if ((rxdata & UARTn_RXDATAX_FERR) && !(rxdata & UARTn_RXDATAX_RXDATA__MASK)) { and RXDATA__MASK with 2 underscores? perhaps just one _? > +static int efm32_uart_console_setup(struct console *co, char *options) [] > + for (i = 0; i < ARRAY_SIZE(efm32_uart_ports); ++i) { > + if (efm32_uart_ports[i]) { > + pr_warn("efm32-console: fall back to console index %u (from %hhi)\n", > + i, co->index); pr_warn("fall back to ..." [] > + efm_port = efm32_uart_ports[co->index]; > + if (!efm_port) { > + pr_warn("efm32-console: No port at %d\n", co->index); pr_warn("No port at..."