mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yinghai Lu <yinghai@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	"H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
	Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [PATCH 7/7] x86, irq: kill create_irq()
Date: Thu, 26 Jan 2012 23:25:53 -0800	[thread overview]
Message-ID: <1327649153-16477-8-git-send-email-yinghai@kernel.org> (raw)
In-Reply-To: <1327649153-16477-1-git-send-email-yinghai@kernel.org>

create_irq() will return -1 when fail to allocate.
create_irq_nr() will return 0 when fail to allocate.

it only causes confusing.

And now we don't have user for create_irq().

So remove create_irq() for x86.

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
---
 arch/x86/kernel/apic/io_apic.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index cb8c43d..4bda08d 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -3090,21 +3090,6 @@ unsigned int create_irq_nr(unsigned int from, int node)
 	return ret;
 }
 
-int create_irq(void)
-{
-	int node = cpu_to_node(0);
-	unsigned int irq_want;
-	int irq;
-
-	irq_want = nr_irqs_gsi;
-	irq = create_irq_nr(irq_want, node);
-
-	if (irq == 0)
-		irq = -1;
-
-	return irq;
-}
-
 void destroy_irq(unsigned int irq)
 {
 	struct irq_cfg *cfg = irq_get_chip_data(irq);
-- 
1.7.7


      parent reply	other threads:[~2012-01-27  7:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-27  7:25 [PATCH 0/7] x86/irq related fix Yinghai Lu
2012-01-27  7:25 ` [PATCH 1/7] x86, irq: Modify irq chip one time when irq remapping is enabled Yinghai Lu
2012-01-27  7:25 ` [PATCH 2/7] x86, irq: more clear about msix printout Yinghai Lu
2012-01-27  7:25 ` [PATCH 3/7] x86, irq: Let msi-x to shown as MSI-X in /proc/interrupt Yinghai Lu
2012-01-27  7:25 ` [PATCH 4/7] x86, irq: Make dmar_msi/hpet_msi irq_chip name consistent Yinghai Lu
2012-01-27  7:25 ` [PATCH 5/7] ia64, irq: add dummy create_irq_nr() Yinghai Lu
2012-01-27  7:25 ` [PATCH 6/7] iommu, irq: alloc irq_desc for dmar_msi with local node Yinghai Lu
2012-01-27  7:25 ` Yinghai Lu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1327649153-16477-8-git-send-email-yinghai@kernel.org \
    --to=yinghai@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome