From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, axboe@kernel.dk
Cc: tj@kernel.org, sjayaraman@suse.com,
gouders@et.bocholt.fh-gelsenkirchen.de, vgoyal@redhat.com
Subject: [PATCH 2/2] floppy: Fix a crash during rmmod
Date: Mon, 30 Jan 2012 09:59:51 -0500 [thread overview]
Message-ID: <1327935591-26812-3-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1327935591-26812-1-git-send-email-vgoyal@redhat.com>
floppy driver does not call add_disk() on all the drives hence we don't take
gendisk reference on request queue for these drives. Don't call put_disk()
with disk->queue set, otherwise we try to put the reference we never took.
Reported-and-tested-by: Dirk Gouders <gouders@et.bocholt.fh-gelsenkirchen.de>
Signed-off-by: Vivek Goyal<vgoyal@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
drivers/block/floppy.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 401ba78..9baf11e 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -4585,6 +4585,15 @@ static void __exit floppy_module_exit(void)
platform_device_unregister(&floppy_device[drive]);
}
blk_cleanup_queue(disks[drive]->queue);
+
+ /*
+ * These disks have not called add_disk(). Don't put down
+ * queue reference in put_disk().
+ */
+ if (!(allowed_drive_mask & (1 << drive)) ||
+ fdc_state[FDC(drive)].version == FDC_NONE)
+ disks[drive]->queue = NULL;
+
put_disk(disks[drive]);
}
--
1.7.4.4
next prev parent reply other threads:[~2012-01-30 15:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-30 14:59 [PATCH 0/2] floppy: Fix couple of crashes during init and module removal Vivek Goyal
2012-01-30 14:59 ` [PATCH 1/2] floppy: Cleanup disk->queue before caling put_disk() if add_disk() was never called Vivek Goyal
2012-01-30 14:59 ` Vivek Goyal [this message]
2012-02-08 18:14 ` [PATCH 0/2] floppy: Fix couple of crashes during init and module removal Vivek Goyal
2012-02-08 19:03 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327935591-26812-3-git-send-email-vgoyal@redhat.com \
--to=vgoyal@redhat.com \
--cc=axboe@kernel.dk \
--cc=gouders@et.bocholt.fh-gelsenkirchen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sjayaraman@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome