From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173Ab2AaBC7 (ORCPT ); Mon, 30 Jan 2012 20:02:59 -0500 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:63527 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753035Ab2AaBC5 (ORCPT ); Mon, 30 Jan 2012 20:02:57 -0500 X-AuditID: 9c93016f-b7c20ae000005067-83-4f273dbfd301 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , linux-kernel@vger.kernel.org, David Ahern Subject: [PATCH v2 2/2] perf: Add error message for EMFILE Date: Tue, 31 Jan 2012 10:15:16 +0900 Message-Id: <1327972517-5055-2-git-send-email-namhyung.kim@lge.com> X-Mailer: git-send-email 1.7.9.rc1.dirty In-Reply-To: <1327972517-5055-1-git-send-email-namhyung.kim@lge.com> References: <1327972517-5055-1-git-send-email-namhyung.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When a user tries to open so many event on multiple tasks/cpus, perf_event_open syscall may fail with EMFILE. Provide an advice for that case. Signed-off-by: Namhyung Kim Cc: David Ahern --- tools/perf/builtin-record.c | 5 +++++ tools/perf/builtin-stat.c | 4 ++++ tools/perf/builtin-top.c | 3 ++- 3 files changed, 11 insertions(+), 1 deletions(-) diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 32870eef952f..a334008a1853 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -249,6 +249,11 @@ try_again: ui__warning("The %s event is not supported.\n", event_name(pos)); exit(EXIT_FAILURE); + } else if (err == EMFILE) { + ui__warning("Too many events are opened.\n" + "Try again after reducing the number of events,\n" + "tasks and/or cpus.\n"); + exit(EXIT_FAILURE); } printf("\n"); diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 459b8620a5d9..7c5421c7af06 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -477,6 +477,10 @@ static int run_perf_stat(int argc __used, const char **argv) "\t Consider tweaking" " /proc/sys/kernel/perf_event_paranoid or running as root.", system_wide ? "system-wide " : ""); + } else if (errno == EMFILE) { + error("Too many events are opened.\n" + "\t Try again after reducing the number of events,\n" + "\t tasks and/or cpus."); } else { error("open_counter returned with %d (%s). " "/bin/dmesg may provide additional information.\n", diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index e8b033c074f9..987af3695218 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -899,7 +899,8 @@ try_again: goto out_err; } else if (err == EMFILE) { ui__warning("Too many events are opened.\n" - "Try again after reducing the number of events\n"); + "Try again after reducing the number of events,\n" + "tasks and/or cpus.\n"); goto out_err; } -- 1.7.9.rc1.dirty