Re: [PATCH] IB/ehca: use kthread_create_on_node

[Eric Dumazet <eric.dumazet@gmail.com>]

Le vendredi 29 juillet 2011 à 09:15 +0200, Eric Dumazet a écrit :
> Since create_comp_task() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> CC: Hoang-Nam Nguyen <hnguyen@de.ibm.com>
> CC: Christoph Raisch <raisch@de.ibm.com>
> CC: Roland Dreier <roland@kernel.org>
> CC: Sean Hefty <sean.hefty@intel.com>
> ---
>  drivers/infiniband/hw/ehca/ehca_irq.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c
> index e571e60..5358900 100644
> --- a/drivers/infiniband/hw/ehca/ehca_irq.c
> +++ b/drivers/infiniband/hw/ehca/ehca_irq.c
> @@ -786,7 +786,8 @@ static struct task_struct *create_comp_task(struct ehca_comp_pool *pool,
>  	spin_lock_init(&cct->task_lock);
>  	INIT_LIST_HEAD(&cct->cq_list);
>  	init_waitqueue_head(&cct->wait_queue);
> -	cct->task = kthread_create(comp_task, cct, "ehca_comp/%d", cpu);
> +	cct->task = kthread_create_on_node(comp_task, cct, cpu_to_node(cpu),
> +					   "ehca_comp/%d", cpu);
>  
>  	return cct->task;
>  }
> 


Any news on this patch ?

Should I submit it again ?